Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: services/asset_bundle/asset_bundle_impl.cc

Issue 1206673006: Don't use base::WorkerPool in the asset_bundle app. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: move comment Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/asset_bundle/asset_bundle_impl.h ('k') | services/asset_bundle/asset_unpacker_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/asset_bundle/asset_bundle_impl.cc
diff --git a/services/asset_bundle/asset_bundle_impl.cc b/services/asset_bundle/asset_bundle_impl.cc
index 304838c0c9772bfd336bf81e0ff1cf43fd8328fa..049add80863622cf791ac3f51d803684f0cef600 100644
--- a/services/asset_bundle/asset_bundle_impl.cc
+++ b/services/asset_bundle/asset_bundle_impl.cc
@@ -8,7 +8,6 @@
#include "base/files/file_path.h"
#include "base/files/file_util.h"
#include "base/logging.h"
-#include "base/threading/worker_pool.h"
#include "mojo/common/data_pipe_utils.h"
namespace mojo {
@@ -21,8 +20,11 @@ void Ignored(bool) {
} // namespace
AssetBundleImpl::AssetBundleImpl(InterfaceRequest<AssetBundle> request,
- scoped_ptr<base::ScopedTempDir> asset_dir)
- : binding_(this, request.Pass()), asset_dir_(asset_dir.Pass()) {
+ scoped_ptr<base::ScopedTempDir> asset_dir,
+ scoped_refptr<base::TaskRunner> worker_runner)
+ : binding_(this, request.Pass()),
+ asset_dir_(asset_dir.Pass()),
+ worker_runner_(worker_runner.Pass()) {
}
AssetBundleImpl::~AssetBundleImpl() {
@@ -43,10 +45,8 @@ void AssetBundleImpl::GetAsStream(
return;
}
- scoped_refptr<base::TaskRunner> worker =
- base::WorkerPool::GetTaskRunner(true);
- common::CopyFromFile(asset_path, pipe.producer_handle.Pass(), 0, worker.get(),
- base::Bind(&Ignored));
+ common::CopyFromFile(asset_path, pipe.producer_handle.Pass(), 0,
+ worker_runner_.get(), base::Bind(&Ignored));
}
} // namespace asset_bundle
« no previous file with comments | « services/asset_bundle/asset_bundle_impl.h ('k') | services/asset_bundle/asset_unpacker_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698