Omnibox: Bug Fixes for Reverse Title

Omnibox: Bug Fixes for Reverse Title

Do the swapping at UI time, not AutocompleteResult assembly time.
This means the result that gets stored in the shortcuts database
is correct.
Incidentally, this removes support for this experimental feature
from mac (and I suppose Android) because I only wrote the views code.

Require a match in the description (title), thus preventing the
swapping from triggering on the bug example input of "7".
(Does not match in the title.)

BUG=338066
Committed: https://crrev.com/e18665267d4a3f1c1fc3fa9851a562f6c28a70f7
Cr-Commit-Position: refs/heads/master@{#335873}

[Mark P, 2015-06-23 21:51:03]

mpearson@chromium.org changed reviewers:
+ pkasting@chromium.org

[Mark P, 2015-06-23 21:52:00]

Peter,

Please take a look, thanks.

--mark

[Peter Kasting, 2015-06-23 21:56:37]

As I said in comment 23 of the bug: I don't think we should require whitespace
in the input.  I think instead we should require a match in the description, and
allow different matches to be ordered differently.  I would like to play with
this before abandoning it as hopeless.

[Mark P, 2015-06-23 22:27:59]

Okay, with your approach.

--mark

[Peter Kasting, 2015-06-23 22:57:05]

LGTM

https://codereview.chromium.org/1206673002/diff/20001/components/omnibox/auto...
File components/omnibox/autocomplete_match.h (right):

https://codereview.chromium.org/1206673002/diff/20001/components/omnibox/auto...
components/omnibox/autocomplete_match.h:157: static bool HasMatch(const
ACMatchClassifications& classifications);
Nit: HasMatchStyle() would be slightly clearer.

[Mark P, 2015-06-24 03:52:45]

https://codereview.chromium.org/1206673002/diff/20001/components/omnibox/auto...
File components/omnibox/autocomplete_match.h (right):

https://codereview.chromium.org/1206673002/diff/20001/components/omnibox/auto...
components/omnibox/autocomplete_match.h:157: static bool HasMatch(const
ACMatchClassifications& classifications);
On 2015/06/23 22:57:05, Peter Kasting wrote:
> Nit: HasMatchStyle() would be slightly clearer.

Done.

[Mark P, 2015-06-24 03:55:32]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2015-06-24 03:55:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1206673002/#ps40001
(title: "HasMatch -> HasMatchStyle")

[commit-bot: I haz the power, 2015-06-24 03:56:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1206673002/40001

[commit-bot: I haz the power, 2015-06-24 05:12:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-24 05:13:46]

Patchset 3 (id:??) landed as
https://crrev.com/e18665267d4a3f1c1fc3fa9851a562f6c28a70f7
Cr-Commit-Position: refs/heads/master@{#335873}