Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: tools/mb/docs/design_spec.md

Issue 1206633003: Update docs and command line flags for MB. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rm_gnisolate
Patch Set: add //tools/mb/docs/README.md Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/mb/docs/design_spec.md
diff --git a/tools/mb/docs/design_spec.md b/tools/mb/docs/design_spec.md
index 5673fae13c6312f3a2149121028dd61fe27e5136..d6067dfd3c8b4a57166c71c6ba71703777c4a766 100644
--- a/tools/mb/docs/design_spec.md
+++ b/tools/mb/docs/design_spec.md
@@ -20,6 +20,9 @@ Ninja files, and the `analyze` step that takes a list of modified files
and a list of targets to build and returns which targets are affected by
the files.
+For more information on how to actually use MB, see
+[the user guide](user_guide.md).
+
## Design
MB is intended to be as simple as possible, and to defer as much work as
@@ -122,7 +125,7 @@ This design allows us to determine easily all of the different sets
of flags that we need to support, but *not* which flags are used on which
host/target combinations.
-It may be that we should really track the latter. Doing so is just a
+It may be that we should really track the latter. Doing so is just a
config file change, however.
### Non-goals
@@ -137,7 +140,7 @@ config file change, however.
the GYP->GN migration is done, and so we should not add things for
developers that can't easily be added to GN itself.
-* MB is not intended to replace the
+* MB is not intended to replace the
[CR tool](https://code.google.com/p/chromium/wiki/CRUserManual). Not
only is it only intended to replace the gyp\_chromium part of `'gclient
runhooks'`, it is not really meant as a developer-facing tool.
@@ -147,7 +150,7 @@ config file change, however.
* Some common flags (goma\_dir being the obvious one) may need to be
specified via the user, and it's unclear how to integrate this with
the concept of build\_configs.
-
+
Right now, MB has hard-coded support for a few flags (i.e., you can
pass the --goma-dir flag, and it will know to expand "${goma\_dir}" in
the string before calling out to the tool. We may want to generalize
« no previous file with comments | « tools/mb/docs/README.md ('k') | tools/mb/docs/user_guide.md » ('j') | tools/mb/mb.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698