Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 1206633003: Update docs and command line flags for MB. (Closed)

Created:
5 years, 6 months ago by Dirk Pranke
Modified:
5 years, 5 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@rm_gnisolate
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update docs and command line flags for MB. This adds the information about how the integration w/ isolates works, and does a bunch of additional cleanup to make sure everything is documented and in sync. R=maruel@chromium.org BUG= Committed: https://crrev.com/747cb269970294b7928ca30a3cde192c90072d13 Cr-Commit-Position: refs/heads/master@{#338951}

Patch Set 1 #

Patch Set 2 : add //tools/mb/docs/README.md #

Total comments: 2

Patch Set 3 : merge to HEAD and update w/ review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -35 lines) Patch
M tools/mb/README.md View 1 chunk +2 lines, -2 lines 0 comments Download
A tools/mb/docs/README.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/mb/docs/design_spec.md View 4 chunks +6 lines, -3 lines 0 comments Download
M tools/mb/docs/user_guide.md View 5 chunks +74 lines, -24 lines 0 comments Download
M tools/mb/mb.py View 1 2 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Dirk Pranke
5 years, 6 months ago (2015-06-24 01:30:21 UTC) #1
M-A Ruel
lgtm, thanks https://codereview.chromium.org/1206633003/diff/20001/tools/mb/mb.py File tools/mb/mb.py (right): https://codereview.chromium.org/1206633003/diff/20001/tools/mb/mb.py#newcode68 tools/mb/mb.py:68: help=('Do not print anything on success, ' ...
5 years, 6 months ago (2015-06-25 13:31:13 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1206633003/diff/20001/tools/mb/mb.py File tools/mb/mb.py (right): https://codereview.chromium.org/1206633003/diff/20001/tools/mb/mb.py#newcode68 tools/mb/mb.py:68: help=('Do not print anything on success, ' On 2015/06/25 ...
5 years, 6 months ago (2015-06-25 16:06:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206633003/40001
5 years, 5 months ago (2015-07-15 20:45:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/72189) (exceeded global retry quota)
5 years, 5 months ago (2015-07-15 20:58:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206633003/40001
5 years, 5 months ago (2015-07-15 21:03:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/97386) (exceeded global retry quota)
5 years, 5 months ago (2015-07-15 21:12:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206633003/40001
5 years, 5 months ago (2015-07-15 22:56:34 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-15 23:53:35 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/747cb269970294b7928ca30a3cde192c90072d13 Cr-Commit-Position: refs/heads/master@{#338951}
5 years, 5 months ago (2015-07-15 23:54:38 UTC) #16
tsergeant
5 years, 5 months ago (2015-07-16 01:32:40 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1234343003/ by tsergeant@chromium.org.

The reason for reverting is: This CL appears to be causing tryjobs to fail. See:

http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...

and https://crbug.com/510655.

Powered by Google App Engine
This is Rietveld 408576698