Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: sky/sdk/lib/widgets/basic.dart

Issue 1206373002: Implement ClipRRect (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'dart:sky' as sky; 5 import 'dart:sky' as sky;
6 6
7 import 'package:vector_math/vector_math.dart'; 7 import 'package:vector_math/vector_math.dart';
8 8
9 import '../painting/text_style.dart'; 9 import '../painting/text_style.dart';
10 import '../rendering/block.dart'; 10 import '../rendering/block.dart';
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 } 99 }
100 100
101 class ClipRect extends OneChildRenderObjectWrapper { 101 class ClipRect extends OneChildRenderObjectWrapper {
102 ClipRect({ String key, Widget child }) 102 ClipRect({ String key, Widget child })
103 : super(key: key, child: child); 103 : super(key: key, child: child);
104 104
105 RenderClipRect get root => super.root; 105 RenderClipRect get root => super.root;
106 RenderClipRect createNode() => new RenderClipRect(); 106 RenderClipRect createNode() => new RenderClipRect();
107 } 107 }
108 108
109 class ClipRRect extends OneChildRenderObjectWrapper {
110 final double xRad;
111 final double yRad;
abarth-chromium 2015/06/25 17:11:21 xRadius and yRadius
112 ClipRRect({ String key, Widget child, this.xRad, this.yRad })
113 : super(key: key, child: child);
114
115 RenderClipRRect get root => super.root;
116 RenderClipRRect createNode() => new RenderClipRRect(xRad: xRad, yRad: yRad);
abarth-chromium 2015/06/25 17:11:21 You're missing a syncRenderObject function. Looks
jackson 2015/06/25 17:21:35 ClipRect and ClipOval are missing them, but Render
117 }
118
109 class ClipOval extends OneChildRenderObjectWrapper { 119 class ClipOval extends OneChildRenderObjectWrapper {
110 ClipOval({ String key, Widget child }) 120 ClipOval({ String key, Widget child })
111 : super(key: key, child: child); 121 : super(key: key, child: child);
112 122
113 RenderClipOval get root => super.root; 123 RenderClipOval get root => super.root;
114 RenderClipOval createNode() => new RenderClipOval(); 124 RenderClipOval createNode() => new RenderClipOval();
115 } 125 }
116 126
117 127
118 // POSITIONING AND SIZING NODES 128 // POSITIONING AND SIZING NODES
(...skipping 352 matching lines...) Expand 10 before | Expand all | Expand 10 after
471 } 481 }
472 482
473 void remove() { 483 void remove() {
474 RenderObjectWrapper ancestor = findAncestor(RenderObjectWrapper); 484 RenderObjectWrapper ancestor = findAncestor(RenderObjectWrapper);
475 assert(ancestor is RenderObjectWrapper); 485 assert(ancestor is RenderObjectWrapper);
476 ancestor.detachChildRoot(this); 486 ancestor.detachChildRoot(this);
477 super.remove(); 487 super.remove();
478 } 488 }
479 489
480 } 490 }
OLDNEW
« sky/sdk/lib/rendering/box.dart ('K') | « sky/sdk/lib/rendering/box.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698