Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1206333002: Fix link error when running `make tools` with skia_shared_lib=1 (Closed)

Created:
5 years, 6 months ago by borenet
Modified:
5 years, 6 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix link error when running `make tools` with skia_shared_lib=1 I'm getting this error, which is fixed by this change: [75/76] LINK skpdiff FAILED: c++ -m64 -pie -Wl,-rpath=\$ORIGIN/lib/ -Wl,-rpath-link=lib/ -o skpdiff -Wl,--start-group obj/tools/skpdiff/skpdiff.skpdiff_main.o obj/tools/skpdiff/skpdiff.SkDiffContext.o obj/tools/skpdiff/skpdiff.SkImageDiffer.o obj/tools/skpdiff/skpdiff.SkPMetric.o obj/tools/skpdiff/skpdiff.skpdiff_util.o obj/tools/skpdiff/skpdiff.SkDifferentPixelsMetric_cpu.o obj/gyp/libflags.a obj/gyp/libpicture_utils.a -Wl,--end-group lib/libskia.so -lrt -lz /usr/bin/ld: obj/tools/skpdiff/skpdiff.SkDiffContext.o: undefined reference to symbol 'pthread_mutexattr_settype@@GLIBC_2.2.5' //lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status BUG=skia: Committed: https://skia.googlesource.com/skia/+/283714f0de143c79a412e2580dfcad1ddf9b7839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/tools.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
borenet
5 years, 6 months ago (2015-06-25 14:48:57 UTC) #2
mtklein
lgtm
5 years, 6 months ago (2015-06-25 14:52:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206333002/1
5 years, 6 months ago (2015-06-25 14:53:05 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 15:05:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/283714f0de143c79a412e2580dfcad1ddf9b7839

Powered by Google App Engine
This is Rietveld 408576698