use templates instead of macros to build blitters

use templates instead of macros to build blitters

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=14178

[mtklein, 2014-01-03 15:49:57]

https://codereview.chromium.org/120633004/diff/60001/src/core/SkBitmapProcSta...
File src/core/SkBitmapProcState_matrixProcs.cpp (right):

https://codereview.chromium.org/120633004/diff/60001/src/core/SkBitmapProcSta...
src/core/SkBitmapProcState_matrixProcs.cpp:59: class ClampTileProcs {
I usually see these traity classes as structs, which helps a little to emphasize
it's just a namespace, it's all public, and there's no point in instantiating
one.

https://codereview.chromium.org/120633004/diff/60001/src/core/SkBitmapProcSta...
src/core/SkBitmapProcState_matrixProcs.cpp:64: static unsigned Y(const
SkBitmapProcState&, SkFixed fx, int max) {
These Y methods take fy, no?

[reed1, 2014-04-11 13:12:27]

https://codereview.chromium.org/120633004/diff/60001/src/core/SkBitmapProcSta...
File src/core/SkBitmapProcState_matrixProcs.cpp (right):

https://codereview.chromium.org/120633004/diff/60001/src/core/SkBitmapProcSta...
src/core/SkBitmapProcState_matrixProcs.cpp:59: class ClampTileProcs {
On 2014/01/03 15:49:57, mtklein wrote:
> I usually see these traity classes as structs, which helps a little to
emphasize
> it's just a namespace, it's all public, and there's no point in instantiating
> one.

Done.

https://codereview.chromium.org/120633004/diff/60001/src/core/SkBitmapProcSta...
src/core/SkBitmapProcState_matrixProcs.cpp:64: static unsigned Y(const
SkBitmapProcState&, SkFixed fx, int max) {
On 2014/01/03 15:49:57, mtklein wrote:
> These Y methods take fy, no?

Done.

[mtklein, 2014-04-11 14:57:35]

On 2014/04/11 13:12:27, reed1 wrote:
>
https://codereview.chromium.org/120633004/diff/60001/src/core/SkBitmapProcSta...
> File src/core/SkBitmapProcState_matrixProcs.cpp (right):
> 
>
https://codereview.chromium.org/120633004/diff/60001/src/core/SkBitmapProcSta...
> src/core/SkBitmapProcState_matrixProcs.cpp:59: class ClampTileProcs {
> On 2014/01/03 15:49:57, mtklein wrote:
> > I usually see these traity classes as structs, which helps a little to
> emphasize
> > it's just a namespace, it's all public, and there's no point in
instantiating
> > one.
> 
> Done.
> 
>
https://codereview.chromium.org/120633004/diff/60001/src/core/SkBitmapProcSta...
> src/core/SkBitmapProcState_matrixProcs.cpp:64: static unsigned Y(const
> SkBitmapProcState&, SkFixed fx, int max) {
> On 2014/01/03 15:49:57, mtklein wrote:
> > These Y methods take fy, no?
> 
> Done.

Not seeing any changes between PS2 and PS3?

[reed1, 2014-04-11 15:00:15]

On 2014/04/11 14:57:35, mtklein wrote:
> On 2014/04/11 13:12:27, reed1 wrote:
> >
>
https://codereview.chromium.org/120633004/diff/60001/src/core/SkBitmapProcSta...
> > File src/core/SkBitmapProcState_matrixProcs.cpp (right):
> > 
> >
>
https://codereview.chromium.org/120633004/diff/60001/src/core/SkBitmapProcSta...
> > src/core/SkBitmapProcState_matrixProcs.cpp:59: class ClampTileProcs {
> > On 2014/01/03 15:49:57, mtklein wrote:
> > > I usually see these traity classes as structs, which helps a little to
> > emphasize
> > > it's just a namespace, it's all public, and there's no point in
> instantiating
> > > one.
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/120633004/diff/60001/src/core/SkBitmapProcSta...
> > src/core/SkBitmapProcState_matrixProcs.cpp:64: static unsigned Y(const
> > SkBitmapProcState&, SkFixed fx, int max) {
> > On 2014/01/03 15:49:57, mtklein wrote:
> > > These Y methods take fy, no?
> > 
> > Done.
> 
> Not seeing any changes between PS2 and PS3?

Yea, it is done locally, but still debugging other things. Sent my reply too
soon.

[reed1, 2014-04-11 18:40:06]

ok, passes all tests locally. ptal

[reed1, 2014-04-11 18:41:24]

If this lands, next steps would be...

2. do the filter procs as well, so I can delete the _matrix.h file completely
3. attack the filter procs
4. (the payoff) try writing filter procs for unpremul and srgb

[mtklein, 2014-04-11 21:54:15]

Oooh, I see what you mean about that being a subtle bug.

LGTM

[reed1, 2014-04-14 12:43:57]

On 2014/04/11 21:54:15, mtklein wrote:
> Oooh, I see what you mean about that being a subtle bug.
> 
> LGTM

Crazy that it built and linked... and we never actually had built that function
(tho the compare against it linked...)

[reed1, 2014-04-14 12:44:01]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-04-14 12:44:13]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/120633004/170001

[commit-bot: I haz the power, 2014-04-14 12:48:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-14 12:48:04]

Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for
step(s) BuildEverything
http://skia-tree-status.appspot.com/redirect/compile-buildbots/buildstatus?bu...

[reed1, 2014-04-14 13:10:57]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-04-14 13:11:08]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/120633004/190001

[mtklein, 2014-04-14 14:10:16]

https://codereview.chromium.org/120633004/diff/150001/src/core/SkBitmapProcSt...
File src/core/SkBitmapProcState_matrixProcs.cpp (right):

https://codereview.chromium.org/120633004/diff/150001/src/core/SkBitmapProcSt...
src/core/SkBitmapProcState_matrixProcs.cpp:79: void
ClampX_ClampY_nofilter_scale(const SkBitmapProcState& s, uint32_t xy[],
As far as I can tell, these functions always existed, they just weren't in the
list of procs?

[commit-bot: I haz the power, 2014-04-14 15:02:43]

Change committed as 14178

[bungeman-skia, 2014-04-14 15:45:36]

A revert of this CL has been created in
https://codereview.chromium.org/236593006/ by bungeman@google.com.

The reason for reverting is: Broke build..