Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1206323004: Remove INJECT_EVENTS permissions from test APKs. (Closed)

Created:
5 years, 5 months ago by newt (away)
Modified:
5 years, 5 months ago
Reviewers:
Ted C, jbudorick
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yfriedman+watch_chromium.org, darin (slow to review), klundberg+watch_chromium.org, ben+mojo_chromium.org, jbudorick+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove INJECT_EVENTS permissions from test APKs. This permission only applies to system apps, so the test APKs couldn't actually use the permission. BUG=502028 Committed: https://crrev.com/90d3bdc22f7826554dc0221f08bcc035bc7d9e54 Cr-Commit-Position: refs/heads/master@{#336938}

Patch Set 1 #

Patch Set 2 : don't touch src/mojo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M build/android/lint/suppressions.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/javatests/AndroidManifest.xml View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/shell/javatests/AndroidManifest.xml View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/sync_shell/javatests/AndroidManifest.xml View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/android/javatests/src/org/chromium/content/browser/test/util/KeyUtils.java View 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/android/javatests/AndroidManifest.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
newt (away)
PTAL
5 years, 5 months ago (2015-06-30 21:23:42 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206323004/1
5 years, 5 months ago (2015-06-30 21:24:47 UTC) #4
Ted C
lgtm +jbudorick -- fyi
5 years, 5 months ago (2015-06-30 21:48:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206323004/20001
5 years, 5 months ago (2015-06-30 22:27:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-01 00:37:47 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 00:38:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90d3bdc22f7826554dc0221f08bcc035bc7d9e54
Cr-Commit-Position: refs/heads/master@{#336938}

Powered by Google App Engine
This is Rietveld 408576698