LayoutTests/media/mediasession/mediasession-constructor.html - Issue 1206283002: Add MediaSession runtime flag along with stub MediaSession object

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/mediasession/mediasession-constructor.html

Issue 1206283002: Add MediaSession runtime flag along with stub MediaSession object (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add OWNERS and fix idl "coding style" Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Test that the media session constructor exists</title>
	philipj_slow 2015/06/26 12:34:40 Maybe just "MediaSession() constructor" as this te Maybe just "MediaSession() constructor" as this test will likely evolve to also test the behavior of the no-argument constructor, where some attribute (maybe transient) can be different. (There's also the Simon Pieters-influenced idea that the title should describe what is being tested, not what the expected behavior is.) davve 2015/06/26 12:50:50 Done. Show quoted text On 2015/06/26 12:34:40, philipj wrote: > Maybe just "MediaSession() constructor" as this test will likely evolve to also > test the behavior of the no-argument constructor, where some attribute (maybe > transient) can be different. (There's also the Simon Pieters-influenced idea > that the title should describe what is being tested, not what the expected > behavior is.) Done.
	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <div id="log"></div>

	6 <script>

	7 test(function() {

	8 // Test expects to be run either manually by passing the MediaSession flag or as part of the virtual mediasession

	9 // testsuite.

	10 assert_true(!window.internals \|\| window.internals.runtimeFlags.mediaSessio nEnabled);

	11

	12 var mediaSession = new MediaSession();
	philipj_slow 2015/06/26 12:34:41 Maybe assert_true(mediaSession instanceof MediaSes Maybe assert_true(mediaSession instanceof MediaSession) for extra paranoia and to not leave mediaSession unused. davve 2015/06/26 12:50:50 Done. Show quoted text On 2015/06/26 12:34:41, philipj wrote: > Maybe assert_true(mediaSession instanceof MediaSession) for extra paranoia and > to not leave mediaSession unused. Done.
	13 });

	14 </script>

OLD	NEW

« no previous file with comments | « LayoutTests/VirtualTestSuites ('k') | LayoutTests/media/mediasession/mediasession-constructor-expected.txt » ('j') | no next file with comments »