Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1206263002: Revert of Reland "Keep a canonical list of shared function infos." (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 6 months ago
Reviewers:
adamk
CC:
v8-dev, Yang, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "Keep a canonical list of shared function infos." (patchset #3 id:40001 of https://codereview.chromium.org/1211453002/) Reason for revert: proxies test failing https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/903/steps/Mjsunit/logs/proxies Original issue's description: > Reland "Keep a canonical list of shared function infos." > > This reverts commit 3164aa7483cb476da84895a3c9810015758fccf9. > > Committed: https://crrev.com/cacb646d80daa429f6915824a741f595db7d5044 > Cr-Commit-Position: refs/heads/master@{#29282} TBR=adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/f7ef0c9921549952011366c5d5b817e38e85f67f Cr-Commit-Position: refs/heads/master@{#29285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -244 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ast.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/ast.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.h View 3 chunks +4 lines, -8 lines 0 comments Download
M src/compiler.cc View 9 chunks +38 lines, -74 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M src/debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/full-codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 10 chunks +13 lines, -26 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -49 lines 0 comments Download
M src/objects-inl.h View 3 chunks +0 lines, -5 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/snapshot/serialize.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/typing.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M test/mjsunit/regress/regress-4121.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Reland "Keep a canonical list of shared function infos."
5 years, 6 months ago (2015-06-25 10:34:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206263002/1
5 years, 6 months ago (2015-06-25 10:34:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-25 10:35:00 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 10:35:24 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7ef0c9921549952011366c5d5b817e38e85f67f
Cr-Commit-Position: refs/heads/master@{#29285}

Powered by Google App Engine
This is Rietveld 408576698