Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 1206203002: [tracing] Fixing freelist snapshot of blink gc dump provider. (Closed)

Created:
4 years, 10 months ago by ssid
Modified:
4 years, 10 months ago
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[tracing] Fixing freelist snapshot of blink gc dump provider. m_firstUnsweptPage after makeConsistentForMutator() is always null. So, this cannot be checked during freelist snapshot. The check is not useful here since there cannot be page dump when there is no freelist. Hence this is removed. BUG=490087 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/heap/Heap.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
ssid
4 years, 10 months ago (2015-06-25 06:22:28 UTC) #2
haraken
LGTM
4 years, 10 months ago (2015-06-25 06:25:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206203002/1
4 years, 10 months ago (2015-06-25 09:21:45 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 09:25:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197807

Powered by Google App Engine
This is Rietveld 408576698