Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Unified Diff: pkg/analyzer/test/src/task/dart_test.dart

Issue 1206183002: Clean up and rename RESOLVED_UNIT* vars. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/task/dart_test.dart
diff --git a/pkg/analyzer/test/src/task/dart_test.dart b/pkg/analyzer/test/src/task/dart_test.dart
index 5ab7bae6eb30d65c0850f3b638b782fd52a0cf9c..e8b58134213a12e130e2a0b210daad715854d874 100644
--- a/pkg/analyzer/test/src/task/dart_test.dart
+++ b/pkg/analyzer/test/src/task/dart_test.dart
@@ -2391,15 +2391,15 @@ main(A a) {
''');
LibrarySpecificUnit target = new LibrarySpecificUnit(source, source);
// prepare unit and "a.m()" invocation
- computeResult(target, RESOLVED_UNIT6);
- CompilationUnit unit = outputs[RESOLVED_UNIT6];
+ computeResult(target, RESOLVED_UNIT5);
+ CompilationUnit unit = outputs[RESOLVED_UNIT5];
// walk the AST
FunctionDeclaration function = unit.declarations[1];
BlockFunctionBody body = function.functionExpression.body;
ExpressionStatement statement = body.block.statements[0];
MethodInvocation invocation = statement.expression;
expect(task, new isInstanceOf<ResolveUnitReferencesTask>());
- expect(unit, same(outputs[RESOLVED_UNIT6]));
+ expect(unit, same(outputs[RESOLVED_UNIT5]));
// a.m() is resolved now
expect(invocation.methodName.staticElement, isNotNull);
}
@@ -2413,7 +2413,7 @@ main(A a) {
}
''');
LibrarySpecificUnit target = new LibrarySpecificUnit(source, source);
- computeResult(target, RESOLVED_UNIT6);
+ computeResult(target, RESOLVED_UNIT5);
expect(task, new isInstanceOf<ResolveUnitReferencesTask>());
// validate
_fillErrorListener(RESOLVE_REFERENCES_ERRORS);
@@ -2439,10 +2439,10 @@ main() {
new A<int>().m();
}
''');
- computeResult(new LibrarySpecificUnit(sourceC, sourceC), RESOLVED_UNIT6);
+ computeResult(new LibrarySpecificUnit(sourceC, sourceC), RESOLVED_UNIT5);
expect(task, new isInstanceOf<ResolveUnitReferencesTask>());
// validate
- CompilationUnit unit = outputs[RESOLVED_UNIT6];
+ CompilationUnit unit = outputs[RESOLVED_UNIT5];
expect(unit, isNotNull);
{
FunctionDeclaration functionDeclaration = unit.declarations[0];
@@ -2467,10 +2467,10 @@ class B extends A {}
int f(String p) => p.length;
''');
LibrarySpecificUnit target = new LibrarySpecificUnit(source, source);
- computeResult(target, RESOLVED_UNIT4);
+ computeResult(target, RESOLVED_UNIT3);
expect(task, new isInstanceOf<ResolveUnitTypeNamesTask>());
// validate
- CompilationUnit unit = outputs[RESOLVED_UNIT4];
+ CompilationUnit unit = outputs[RESOLVED_UNIT3];
{
ClassDeclaration nodeA = unit.declarations[0];
ClassDeclaration nodeB = unit.declarations[1];
@@ -2506,10 +2506,10 @@ typedef int F(G g);
typedef String G(int p);
''');
LibrarySpecificUnit target = new LibrarySpecificUnit(source, source);
- computeResult(target, RESOLVED_UNIT4);
+ computeResult(target, RESOLVED_UNIT3);
expect(task, new isInstanceOf<ResolveUnitTypeNamesTask>());
// validate
- CompilationUnit unit = outputs[RESOLVED_UNIT4];
+ CompilationUnit unit = outputs[RESOLVED_UNIT3];
FunctionTypeAlias nodeF = unit.declarations[0];
FunctionTypeAlias nodeG = unit.declarations[1];
{
@@ -2559,7 +2559,7 @@ main() {
}
''');
LibrarySpecificUnit target = new LibrarySpecificUnit(source, source);
- computeResult(target, RESOLVED_UNIT5);
+ computeResult(target, RESOLVED_UNIT4);
expect(task, new isInstanceOf<ResolveVariableReferencesTask>());
}
@@ -2579,10 +2579,10 @@ main() {
}
''');
LibrarySpecificUnit target = new LibrarySpecificUnit(source, source);
- computeResult(target, RESOLVED_UNIT5);
+ computeResult(target, RESOLVED_UNIT4);
expect(task, new isInstanceOf<ResolveVariableReferencesTask>());
// validate
- CompilationUnit unit = outputs[RESOLVED_UNIT5];
+ CompilationUnit unit = outputs[RESOLVED_UNIT4];
FunctionElement main = unit.element.functions[0];
expectMutated(main.localVariables[0], isFalse, isFalse);
expectMutated(main.localVariables[1], isFalse, isTrue);
@@ -2602,10 +2602,10 @@ main(p1, p2, p3, p4) {
}
''');
LibrarySpecificUnit target = new LibrarySpecificUnit(source, source);
- computeResult(target, RESOLVED_UNIT5);
+ computeResult(target, RESOLVED_UNIT4);
expect(task, new isInstanceOf<ResolveVariableReferencesTask>());
// validate
- CompilationUnit unit = outputs[RESOLVED_UNIT5];
+ CompilationUnit unit = outputs[RESOLVED_UNIT4];
FunctionElement main = unit.element.functions[0];
expectMutated(main.parameters[0], isFalse, isFalse);
expectMutated(main.parameters[1], isFalse, isTrue);
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698