Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1206163002: Remove chrome://flags/#enable-app-list, move kEnableAppList to app_list:: (Closed)

Created:
5 years, 6 months ago by tapted
Modified:
5 years, 5 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, tfarina, Matt Giuca, tapted, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove chrome://flags/#enable-app-list, move kEnableAppList to app_list:: chrome://flags/#enable-app-list only functions for Desktop Linux. It's no longer required and there's a TODO to remove it. The switch, kEnableAppList is still used to enable the app list from the command line (rather than having to go to the web store), but it doesn't need to be a persistent chrome://flag. For consistency with the other switches, it also doesn't belong in chrome_switches. BUG=299250 Committed: https://crrev.com/1e0de6aa93e9534a4c88abd457e4169f6fe4c863 Cr-Commit-Position: refs/heads/master@{#336524}

Patch Set 1 #

Patch Set 2 : fix include #

Total comments: 2

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -41 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 chunks +7 lines, -19 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 2 chunks +0 lines, -8 lines 0 comments Download
M ui/app_list/app_list_switches.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ui/app_list/app_list_switches.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
tapted
Hi Matt, ptal https://codereview.chromium.org/1206163002/diff/20001/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): https://codereview.chromium.org/1206163002/diff/20001/chrome/browser/about_flags.cc#oldcode1365 chrome/browser/about_flags.cc:1365: {"enable-surface-worker", note this was also under ...
5 years, 6 months ago (2015-06-25 06:07:38 UTC) #2
Matt Giuca
Yay, thanks Trent, LGTM! https://codereview.chromium.org/1206163002/diff/20001/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): https://codereview.chromium.org/1206163002/diff/20001/chrome/browser/about_flags.cc#oldcode1365 chrome/browser/about_flags.cc:1365: {"enable-surface-worker", On 2015/06/25 06:07:38, tapted ...
5 years, 6 months ago (2015-06-26 08:15:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206163002/20001
5 years, 6 months ago (2015-06-26 08:16:02 UTC) #5
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-26 08:18:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1206163002/40001
5 years, 5 months ago (2015-06-29 01:56:08 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-06-29 02:50:11 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 02:51:13 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1e0de6aa93e9534a4c88abd457e4169f6fe4c863
Cr-Commit-Position: refs/heads/master@{#336524}

Powered by Google App Engine
This is Rietveld 408576698