Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1719)

Unified Diff: ipc/attachment_broker_win.h

Issue 1206093002: Update ChannelReader to use AttachmentBroker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@attachment_broker3_listener
Patch Set: Comments from tsepez. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/attachment_broker.cc ('k') | ipc/attachment_broker_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/attachment_broker_win.h
diff --git a/ipc/attachment_broker_win.h b/ipc/attachment_broker_win.h
index 5df2c9a2395b9fcba21d7d53307db751112d7148..1a81b093182cef0ec44ea377a3ff2a33326aac85 100644
--- a/ipc/attachment_broker_win.h
+++ b/ipc/attachment_broker_win.h
@@ -10,6 +10,7 @@
#include "base/gtest_prod_util.h"
#include "base/memory/ref_counted.h"
#include "ipc/attachment_broker.h"
+#include "ipc/brokerable_attachment.h"
#include "ipc/handle_attachment_win.h"
#include "ipc/ipc_export.h"
@@ -31,8 +32,9 @@ class IPC_EXPORT AttachmentBrokerWin : public IPC::AttachmentBroker {
// IPC::AttachmentBroker overrides.
bool SendAttachmentToProcess(const BrokerableAttachment* attachment,
base::ProcessId destination_process) override;
- bool GetAttachmentWithId(BrokerableAttachment::AttachmentId id,
- BrokerableAttachment* attachment) override;
+ bool GetAttachmentWithId(
+ BrokerableAttachment::AttachmentId id,
+ scoped_refptr<BrokerableAttachment>* attachment) override;
// IPC::Listener overrides.
bool OnMessageReceived(const Message& message) override;
@@ -44,6 +46,7 @@ class IPC_EXPORT AttachmentBrokerWin : public IPC::AttachmentBroker {
private:
FRIEND_TEST_ALL_PREFIXES(AttachmentBrokerWinTest, ReceiveValidMessage);
FRIEND_TEST_ALL_PREFIXES(AttachmentBrokerWinTest, ReceiveInvalidMessage);
+ using AttachmentVector = std::vector<scoped_refptr<BrokerableAttachment>>;
// IPC message handlers.
void OnWinHandleHasBeenDuplicated(
@@ -54,7 +57,7 @@ class IPC_EXPORT AttachmentBrokerWin : public IPC::AttachmentBroker {
// A std::vector is used instead of a std::map because this container is
// expected to have few elements, for which a std::vector is expected to have
// better performance.
- std::vector<scoped_refptr<BrokerableAttachment>> attachments_;
+ AttachmentVector attachments_;
// |sender_| is used to send Messages to the broker. |sender_| must live at
// least as long as this instance.
« no previous file with comments | « ipc/attachment_broker.cc ('k') | ipc/attachment_broker_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698