ipc/ipc_channel_posix.h - Issue 1206093002: Update ChannelReader to use AttachmentBroker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_channel_posix.h

Issue 1206093002: Update ChannelReader to use AttachmentBroker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@attachment_broker3_listener

Patch Set: Add an optimization to immediately dispatch messages after translation. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/ipc_channel_posix.h

diff --git a/ipc/ipc_channel_posix.h b/ipc/ipc_channel_posix.h

index 879adc3408561e5f108c2e9b70ea9294ee062d01..cc26d5bfc9c9f53cec18a76a13843e3b5d294b61 100644

--- a/ipc/ipc_channel_posix.h

+++ b/ipc/ipc_channel_posix.h

@@ -79,7 +79,8 @@ class IPC_EXPORT ChannelPosix : public Channel,

// ChannelReader implementation.

ReadState ReadData(char* buffer, int buffer_len, int* bytes_read) override;

- bool WillDispatchInputMessage(Message* msg) override;

+ bool ShouldDispatchInputMessage(Message* msg) override;

+ bool GetNonBrokeredAttachments(Message* msg) override;

bool DidEmptyInputBuffers() override;

void HandleInternalMessage(const Message& msg) override;

« no previous file with comments | « ipc/ipc_channel_nacl.cc ('k') | ipc/ipc_channel_posix.cc » ('j') | ipc/ipc_channel_reader.cc » ('J')