Update ChannelReader to use AttachmentBroker.

ipc/ipc_channel_reader_unittest.cc

Index: ipc/ipc_channel_reader_unittest.cc
diff --git a/ipc/ipc_channel_reader_unittest.cc b/ipc/ipc_channel_reader_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..71adfc4e156c7dfaec20d7042c5e20b5b70d9598
--- /dev/null
+++ b/ipc/ipc_channel_reader_unittest.cc
@@ -0,0 +1,154 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "build/build_config.h"
+
+#include <set>
+
+#include "ipc/attachment_broker.h"
+#include "ipc/brokerable_attachment.h"
+#include "ipc/ipc_channel_reader.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace IPC {
+namespace internal {
+
+namespace {
+
+class MockAttachment : public BrokerableAttachment {
+ public:
+  MockAttachment(int internal_state) : internal_state_(internal_state) {}
+  MockAttachment(BrokerableAttachment::AttachmentId id)
+      : BrokerableAttachment(id, true), internal_state_(-1) {}
+
+  void PopulateWithAttachment(const BrokerableAttachment* attachment) override {
+    const MockAttachment* mock_attachment =
+        static_cast<const MockAttachment*>(attachment);
+    internal_state_ = mock_attachment->internal_state_;
+  }
+
+#if defined(OS_POSIX)
+  base::PlatformFile TakePlatformFile() override {
+    return base::PlatformFile();
+  }
+#endif  // OS_POSIX
+
+  BrokerableType GetBrokerableType() const override { return WIN_HANDLE; }
+
+ private:
+  ~MockAttachment() override {}
+  // Internal state differentiates MockAttachments.
+  int internal_state_;
+};
+
+class MockAttachmentBroker : public AttachmentBroker {
+ public:
+  typedef std::set<scoped_refptr<BrokerableAttachment>> AttachmentSet;
+
+  bool SendAttachmentToProcess(const BrokerableAttachment* attachment,
+                               base::ProcessId destination_process) override {
+    return false;
+  }
+
+  bool OnMessageReceived(const Message& message) override { return false; }
+
+  bool GetAttachmentWithId(
+      BrokerableAttachment::AttachmentId id,
+      scoped_refptr<BrokerableAttachment>* attachment) override {
+    for (AttachmentSet::iterator it = attachments_.begin();
+         it != attachments_.end(); ++it) {
+      if ((*it)->GetIdentifier() == id) {
+        *attachment = *it;
+        attachments_.erase(it);
+        return true;
+      }
+    }
+    return false;
+  }
+
+  void AddAttachment(scoped_refptr<BrokerableAttachment> attachment) {
+    attachments_.insert(attachment);
+    NotifyObservers(attachment->GetIdentifier());
+  }
+
+ private:
+  // A set of attachmetns that have been brokered and are available to
+  // consumers.
+  AttachmentSet attachments_;
+};
+
+class MockChannelReader : public ChannelReader {
+ public:
+  MockChannelReader()
+      : ChannelReader(nullptr), last_dispatched_message_(nullptr) {}
+
+  ReadState ReadData(char* buffer, int buffer_len, int* bytes_read) override {
+    return READ_FAILED;
+  }
+
+  bool ShouldDispatchInputMessage(Message* msg) override { return true; }
+
+  bool GetNonBrokeredAttachments(Message* msg) override { return true; }
+
+  bool DidEmptyInputBuffers() override { return true; }
+
+  void HandleInternalMessage(const Message& msg) override {}
+
+  void DispatchMessage(Message* m) override { last_dispatched_message_ = m; }
+
+  AttachmentBroker* GetAttachmentBroker() override { return broker_; }
+
+  // This instance takes ownership of |m|.
+  void AddMessageForDispatch(Message* m) {
+    get_queued_messages()->push_back(m);
+  }
+
+  Message* get_last_dispatched_message() { return last_dispatched_message_; }
+
+  void set_broker(AttachmentBroker* broker) { broker_ = broker; }
+
+ private:
+  Message* last_dispatched_message_;
+  AttachmentBroker* broker_;
+};
+
+}  // namespace
+
+TEST(ChannelReaderTest, AttachmentAlreadyBrokered) {
+  MockAttachmentBroker broker;
+  MockChannelReader reader;
+  reader.set_broker(&broker);
+  scoped_refptr<MockAttachment> attachment(new MockAttachment(5));
+  broker.AddAttachment(attachment);
+
+  Message* m = new Message;
+  MockAttachment* needs_brokering_attachment =
+      new MockAttachment(attachment->GetIdentifier());
+  EXPECT_TRUE(m->WriteAttachment(needs_brokering_attachment));
+  reader.AddMessageForDispatch(m);
+  EXPECT_EQ(ChannelReader::DISPATCH_FINISHED, reader.DispatchMessages());
+  EXPECT_EQ(m, reader.get_last_dispatched_message());
+}
+
+TEST(ChannelReaderTest, AttachmentNotYetBrokered) {
+  MockAttachmentBroker broker;
+  MockChannelReader reader;
+  reader.set_broker(&broker);
+  scoped_refptr<MockAttachment> attachment(new MockAttachment(5));
+
+  Message* m = new Message;
+  MockAttachment* needs_brokering_attachment =
+      new MockAttachment(attachment->GetIdentifier());
+  EXPECT_TRUE(m->WriteAttachment(needs_brokering_attachment));
+  reader.AddMessageForDispatch(m);
+  EXPECT_EQ(ChannelReader::DISPATCH_WAITING_ON_BROKER,
+            reader.DispatchMessages());
+  EXPECT_EQ(nullptr, reader.get_last_dispatched_message());
+
+  broker.AddAttachment(attachment);
+  EXPECT_EQ(m, reader.get_last_dispatched_message());
+}
+
+}  // namespace internal
+}  // namespace IPC