Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 120603002: Fix render tree creation in blocks with multiple anonymous blocks and mixed inlines/out of flow chi… (Closed)

Created:
7 years ago by leviw_travelin_and_unemployed
Modified:
7 years ago
CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1
Visibility:
Public.

Description

Fix render tree creation in blocks with multiple anonymous blocks and mixed inlines/out of flow children Out of flow children weren't being inserted into anonymous blocks following the same rules as inlines, which had the effect of breaking a later search for the correct anonymous block to attach other inline renderers in the middle of the containing block. This had the effect of the resulting inlines being separated into different anonymous blocks (and hence visually) when they all should all be siblings of the same anonymous block. BUG=318839 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164278

Patch Set 1 #

Patch Set 2 : Fixed markup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
A LayoutTests/fast/inline/reattach-inlines-in-anonymous-blocks-with-out-of-flow-siblings.html View 1 1 chunk +38 lines, -0 lines 0 comments Download
A + LayoutTests/fast/inline/reattach-inlines-in-anonymous-blocks-with-out-of-flow-siblings-expected.txt View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
leviw_travelin_and_unemployed
Simple 1-line code review. You know you wanna do it ;)
7 years ago (2013-12-23 00:02:29 UTC) #1
esprehn
The markup in your test is busted, you have a closing tag for the head ...
7 years ago (2013-12-23 01:25:43 UTC) #2
leviw_travelin_and_unemployed
Thanks for the weekend review! Markup fixed :)
7 years ago (2013-12-23 01:27:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/120603002/70001
7 years ago (2013-12-23 01:28:19 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-23 02:21:19 UTC) #5
Message was sent while issue was closed.
Change committed as 164278

Powered by Google App Engine
This is Rietveld 408576698