Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issue 120593002: Move traverseLiveNodeListForwardToOffset() to LiveNodeList class (Closed)

Created:
7 years ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Move traverseLiveNodeListForwardToOffset() to LiveNodeList class Move traverseLiveNodeListForwardToOffset() to LiveNodeList class and rename to traverseForwardToOffset() for consistency with HTMLCollection::traverseForwardToOffset(). Also merge traverseChildNodeListForwardToOffset() into LiveNodeList::traverseForwardToOffset() as ChildNodeList is a LiveNodeList and there is no reason to treat it differently from the other LiveNodeList subclasses. Finally, rename isNodeList(CollectionType) to isLiveNodeListType(CollectionType) as it only applies to LiveNodeLists and not other types of NodeLists (e.g. StaticNodeList). This check is always used before casting to a LiveNodeList. R=abarth, esprehn, eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164468

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -28 lines) Patch
M Source/core/dom/LiveNodeList.h View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/CollectionType.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLCollection.cpp View 1 2 6 chunks +22 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Inactive
7 years ago (2013-12-22 22:27:25 UTC) #1
Inactive
Post-holidays ping review? :)
6 years, 11 months ago (2014-01-03 16:08:23 UTC) #2
eseidel
lgtm
6 years, 11 months ago (2014-01-03 17:43:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/120593002/90001
6 years, 11 months ago (2014-01-03 17:43:51 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=6350
6 years, 11 months ago (2014-01-03 18:14:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/120593002/220001
6 years, 11 months ago (2014-01-03 20:31:40 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-03 22:06:31 UTC) #7
Message was sent while issue was closed.
Change committed as 164468

Powered by Google App Engine
This is Rietveld 408576698