Move Add to the elements accessor for everything but dictionary-arguments

Move Add to the elements accessor for everything but dictionary-arguments

BUG=v8:4137
LOG=n

Committed: https://crrev.com/4eed4970fdb89fc8d3ffff1184350b345325d965
Cr-Commit-Position: refs/heads/master@{#29295}

[Toon Verwaest, 2015-06-25 12:51:46]

Patchset #1 (id:1) has been deleted

[Toon Verwaest, 2015-06-25 12:53:15]

verwaest@chromium.org changed reviewers:
+ ishell@chromium.org

[Toon Verwaest, 2015-06-25 12:53:15]

ptal

[Igor Sheludko, 2015-06-25 14:10:07]

lgtm with nits:

https://codereview.chromium.org/1205913002/diff/40001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1205913002/diff/40001/src/elements.cc#newcode...
src/elements.cc:1507: if (attributes != NONE)
new_dictionary->set_requires_slow_elements();
Shouldn't this be done before AddNumberEntry()?

https://codereview.chromium.org/1205913002/diff/40001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1205913002/diff/40001/src/objects.cc#newcode1...
src/objects.cc:12465: if (attributes != NONE)
new_dictionary->set_requires_slow_elements();
Shouldn't this be done before AddNumberEntry()?

[Toon Verwaest, 2015-06-25 14:14:34]

https://codereview.chromium.org/1205913002/diff/40001/src/elements.cc
File src/elements.cc (right):

https://codereview.chromium.org/1205913002/diff/40001/src/elements.cc#newcode...
src/elements.cc:1507: if (attributes != NONE)
new_dictionary->set_requires_slow_elements();
On 2015/06/25 14:10:07, Igor Sheludko wrote:
> Shouldn't this be done before AddNumberEntry()?

Not necessarily. It just needs to be there on the final dictionary that we store
back. Backing stores aren't shared, so the old version just gets thrown away
anyway.

[Toon Verwaest, 2015-06-25 14:15:26]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2015-06-25 14:15:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1205913002/40001

[commit-bot: I haz the power, 2015-06-25 14:17:15]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-06-25 14:17:29]

Patchset 2 (id:??) landed as
https://crrev.com/4eed4970fdb89fc8d3ffff1184350b345325d965
Cr-Commit-Position: refs/heads/master@{#29295}