Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1205843003: Oilpan: promptly finalize XMLHttpRequestProgressEventThrottle. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: promptly finalize XMLHttpRequestProgressEventThrottle. This timer object needs to promptly stop, otherwise we run the risk of timers firing while the object is in non-valid state waiting to be finalized by an ongoing lazy sweep. R=haraken BUG=491488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look.
5 years, 6 months ago (2015-06-24 11:22:36 UTC) #2
haraken
LGTM
5 years, 6 months ago (2015-06-24 11:32:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205843003/1
5 years, 6 months ago (2015-06-24 11:54:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=197736
5 years, 6 months ago (2015-06-24 12:02:20 UTC) #6
sof
5 years, 6 months ago (2015-06-24 15:49:04 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1211593002/ by sigbjornf@opera.com.

The reason for reverting is: This is not well-formed as-is;
XMLHttpRequestProgressEventThrottle is a part object & cannot be eagerly
finalized on its own..

Powered by Google App Engine
This is Rietveld 408576698