Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1205793002: Remove config.h (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove config.h This CL removes all the content from config.h. It doesn't actually delete the file. I'll make that change in a separate CL. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f077faf8bf9ac97c770e13e755b307eda2af61cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -185 lines) Patch
M sky/engine/config.h View 1 chunk +1 line, -97 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/platform/fonts/VDMXParser.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/platform/fonts/opentype/OpenTypeVerticalData.h View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/engine/platform/fonts/opentype/OpenTypeVerticalData.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M sky/engine/platform/fonts/skia/FontCacheSkia.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsTypes.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/wtf/Alignment.h View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/engine/wtf/ArrayBufferContents.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/wtf/Assertions.h View 1 chunk +5 lines, -3 lines 0 comments Download
M sky/engine/wtf/BUILD.gn View 10 chunks +56 lines, -55 lines 0 comments Download
M sky/engine/wtf/ByteOrder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/wtf/CryptographicallyRandomNumber.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/wtf/DynamicAnnotations.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/wtf/FastMalloc.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/wtf/InstanceCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/wtf/MathExtras.h View 1 chunk +3 lines, -0 lines 0 comments Download
A + sky/engine/wtf/OperatingSystem.h View 2 chunks +3 lines, -17 lines 0 comments Download
M sky/engine/wtf/PassRefPtr.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/wtf/StringExtras.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/wtf/ThreadIdentifierDataPthreads.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/wtf/ThreadingPthreads.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/wtf/TypeTraits.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/wtf/Vector.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-24 03:53:05 UTC) #1
abarth-chromium
5 years, 6 months ago (2015-06-24 05:53:43 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f077faf8bf9ac97c770e13e755b307eda2af61cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698