public/web/WebServiceWorkerContextClient.h - Issue 1205783004: Update navigator.services API to use the new services.onconnect event [3/3].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebServiceWorkerContextClient.h

Issue 1205783004: Update navigator.services API to use the new services.onconnect event [3/3]. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@serviceport-serviceside

Patch Set: fix webexposed layout test Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/navigatorconnect/resources/connect-event-worker.js ('K') | « Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | public/web/WebServiceWorkerContextProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: public/web/WebServiceWorkerContextClient.h

diff --git a/public/web/WebServiceWorkerContextClient.h b/public/web/WebServiceWorkerContextClient.h

index cfd459eefa793c5530368802cf7aa71287619c77..4af94199d4a089fa3a305f80bdb8aec82bbd0751 100644

--- a/public/web/WebServiceWorkerContextClient.h

+++ b/public/web/WebServiceWorkerContextClient.h

@@ -130,11 +130,6 @@ public:

// context.

virtual void didHandleSyncEvent(int syncEventID, WebServiceWorkerEventResult result) { }

- // ServiceWorker specific method. Called after CrossOriginConnectEvent

- // (dispatched via WebServiceWorkerContextProxy) is handled by the

- // ServiceWorker's script context.

- virtual void didHandleCrossOriginConnectEvent(int connectEventID, bool acceptConnect) { }

// Ownership of the returned object is transferred to the caller.

// This is called on the main thread.

virtual WebServiceWorkerNetworkProvider* createServiceWorkerNetworkProvider(WebDataSource*) { return nullptr; }