Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: chrome/browser/resources/chromeos/emulator/device_emulator.js

Issue 1205753002: Create chrome://device-emulator and add the ability to get a battery percentage and send an updated… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 cr.define('device_emulator', function() {
2 'use strict';
3
4 function returnBatteryInfo(percent) {
michaelpg 2015/06/24 23:33:48 setBatteryInfo makes more sense I think
michaelpg 2015/06/24 23:33:48 Annotate for Closure (we don't closure-compile yet
rfrappier 2015/06/25 17:09:21 Done.
rfrappier 2015/06/25 17:09:21 Done.
5 var slider = $('batteryPercentSlider');
6 var text = $('batteryPercentText');
7
8 slider.value = percent;
9 text.value = percent.toString();
10 }
11
12 function onBatterySliderChange() {
13 var slider = $('batteryPercentSlider');
14 var text = $('batteryPercentText');
15
16 text.value = slider.value;
17
18 chrome.send('updateBatteryInfo', [parseInt(slider.value)]);
michaelpg 2015/06/24 23:33:48 [slider.valueAsNumber]
rfrappier 2015/06/25 17:09:21 Done.
19 }
20
21 function onBatteryTextChange() {
22 var slider = $('batteryPercentSlider');
23 var text = $('batteryPercentText');
24 var percent = (text.value !== '') ? parseInt(text.value) : 0;
michaelpg 2015/06/24 23:33:48 parseInt will return NaN if given something unpars
rfrappier 2015/06/25 17:09:21 Done.
25
26 if (isNaN(percent)) {
27 percent = 0;
28 text.value = '0';
29 }
30
31 slider.value = percent;
32
33 chrome.send('updateBatteryInfo', [percent]);
34 }
35
36 function initialize() {
37 chrome.send('requestBatteryInfo');
38
39 var slider = $('batteryPercentSlider');
40 var text = $('batteryPercentText');
41
42 slider.addEventListener('input', onBatterySliderChange);
michaelpg 2015/06/24 23:33:48 I'd suggest listening to 'change' instead, so we d
rfrappier 2015/06/25 17:09:21 How about I listen for 'change' for sending the pe
rfrappier 2015/06/25 17:09:21 Done.
michaelpg 2015/06/25 18:18:19 Good idea.
43 text.addEventListener('input', onBatteryTextChange);
44 }
45
46 // Return an object with all of the exports.
47 return {
48 initialize: initialize,
49 returnBatteryInfo: returnBatteryInfo,
50 onBatterySliderChange: onBatterySliderChange,
michaelpg 2015/06/24 23:33:48 Why export on*Change?
rfrappier 2015/06/25 17:09:21 It's not necessary. Not sure why I put them there,
51 onBatteryTextChange: onBatteryTextChange,
52 };
53 });
54
55 document.addEventListener('DOMContentLoaded', device_emulator.initialize);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698