chrome/browser/resources/chromeos/emulator/device_emulator.html - Issue 1205753002: Create chrome://device-emulator and add the ability to get a battery percentage and send an updated…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/chromeos/emulator/device_emulator.html

Issue 1205753002: Create chrome://device-emulator and add the ability to get a battery percentage and send an updated… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/emulator/device_emulator.css ('k') | chrome/browser/resources/chromeos/emulator/device_emulator.js » ('j') | chrome/browser/resources/chromeos/emulator/device_emulator.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>

	3 <head>

	4 <meta charset="utf-8">

	5 <!-- <title i18n-content="deviceEmulatorTitle"></title> -->
	michaelpg 2015/06/24 23:33:48 Don't comment things out. Just use placeholder str Don't comment things out. Just use placeholder strings and add i18n-stuff later. rfrappier 2015/06/25 17:09:20 Done. Show quoted text On 2015/06/24 23:33:48, michaelpg wrote: > Don't comment things out. Just use placeholder strings and add i18n-stuff later. Done.
	6 <link rel="stylesheet" href="device_emulator.css">

	7 <script src="chrome://resources/js/cr.js"></script>

	8 <script src="chrome://resources/js/load_time_data.js"></script>

	9 <script src="chrome://resources/js/util.js"></script>

	10 <script src="strings.js"></script>

	11 <script src="device_emulator.js"></script>

	12 </head>

	13 <body>

	14 <div class="container">
	michaelpg 2015/06/24 23:33:48 throughout: don't use "class" until you need it (w throughout: don't use "class" until you need it (when you add more CSS) rfrappier 2015/06/25 17:09:20 Done. Show quoted text On 2015/06/24 23:33:48, michaelpg wrote: > throughout: don't use "class" until you need it (when you add more CSS) Done.
	15 <!-- <h1 i18n-content="deviceEmulatorTitle"></h1> -->

	16 <h1>ChromeOS Device Emulator</h1>

	17 <hr>

	18

	19 <div class="control-group">

	20 <div class="title">

	21 <h2>Battery/Power Settings</h2>

	22 </div>

	23 <div class="group-body">

	24 <form class="power-settings-form">

	25 <label>

	26 Battery Percentage

	27 <input id="batteryPercentSlider" type="range" min="0" max="100">
	michaelpg 2015/06/24 23:33:48 Per the style guide, element IDs use-hyphen-form. Per the style guide, element IDs use-hyphen-form. https://www.chromium.org/developers/web-development-style-guide rfrappier 2015/06/25 17:09:20 Done. Show quoted text On 2015/06/24 23:33:48, michaelpg wrote: > Per the style guide, element IDs use-hyphen-form. > > https://www.chromium.org/developers/web-development-style-guide Done.
	28 </label>

	29 <input id="batteryPercentText" type="number" min="0" max="100">

	30 </form>

	31 </div>

	32 </div>

	33 </div>

	34

	35 <!-- <script src="chrome://resources/js/i18n_template2.js"></script> -->

	36 </body>

	37 </html>

OLD	NEW