Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 1205733002: Add ListContainer::appendByMoving (Closed)

Created:
4 years, 10 months ago by pdr.
Modified:
4 years, 10 months ago
Reviewers:
chrishtr
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add ListContainer::appendByMoving This patch implements "void ListContainer::appendByMoving(T item)" for appending items to a ListContainer without copying. Because the source item will not be destructed when moving to the destination, a new item is constructed in-place to prevent double-destruction and dev sadness. To support appending derived types when only the base type is known we memcpy the largest possible element size. This is the blink-side version of https://codereview.chromium.org/1202153002. BUG=484943 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197685

Patch Set 1 #

Patch Set 2 : Appease compiler overlords #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -2 lines) Patch
M Source/platform/graphics/ListContainer.h View 1 2 chunks +16 lines, -0 lines 0 comments Download
M Source/platform/graphics/ListContainer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/platform/graphics/ListContainerTest.cpp View 4 chunks +127 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
pdr.
4 years, 10 months ago (2015-06-23 22:51:59 UTC) #2
chrishtr
lgtm
4 years, 10 months ago (2015-06-23 22:53:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205733002/1
4 years, 10 months ago (2015-06-23 22:53:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/48509)
4 years, 10 months ago (2015-06-23 23:01:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205733002/20001
4 years, 10 months ago (2015-06-23 23:03:59 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 00:06:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197685

Powered by Google App Engine
This is Rietveld 408576698