Make attachment broker a subclass of IPC::Listener.

Make attachment broker a subclass of IPC::Listener.

In addition, hook up the IPC::Listener functionality in non-broker proceses.

BUG=466437
Committed: https://crrev.com/7252aa363e57e6a621ee719f0137d5e827e90cec
Cr-Commit-Position: refs/heads/master@{#338798}

[erikchen, 2015-06-23 23:21:59]

erikchen@chromium.org changed reviewers:
+ tsepez@chromium.org

[erikchen, 2015-06-23 23:22:00]

tsepez: Please review.

Note that this CL depends on "Stub in more IPC attachment brokering
functionality.", which is still in review.
https://codereview.chromium.org/1188923003/

[Tom Sepez, 2015-06-29 18:48:37]

https://codereview.chromium.org/1205713002/diff/60001/ipc/BUILD.gn
File ipc/BUILD.gn (right):

https://codereview.chromium.org/1205713002/diff/60001/ipc/BUILD.gn#newcode114
ipc/BUILD.gn:114: "attachment_broker_win_unittest.cc",
Seems strange to be adding this to non-windoes builds?

[erikchen, 2015-07-06 22:12:22]

tsepez: PTAL

https://codereview.chromium.org/1205713002/diff/60001/ipc/BUILD.gn
File ipc/BUILD.gn (right):

https://codereview.chromium.org/1205713002/diff/60001/ipc/BUILD.gn#newcode114
ipc/BUILD.gn:114: "attachment_broker_win_unittest.cc",
On 2015/06/29 18:48:37, Tom Sepez (OOO til 13 jul) wrote:
> Seems strange to be adding this to non-windoes builds?

Files ending with win_unittest.cc automatically get filtered out on non-Windows
builds:

https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD...

[erikchen, 2015-07-07 23:23:12]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-07 23:25:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1205713002/60001

[commit-bot: I haz the power, 2015-07-08 01:26:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-08 01:27:00]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Tom Sepez, 2015-07-13 16:23:57]

lgtm

[erikchen, 2015-07-13 21:14:21]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2015-07-13 21:14:22]

avi: Looking for a content/ OWNER review.

[Avi (use Gerrit), 2015-07-13 21:15:58]

lgtm

[erikchen, 2015-07-13 21:16:15]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-07-13 21:17:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1205713002/60001

[commit-bot: I haz the power, 2015-07-13 21:36:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-13 21:36:08]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

(exceeded global retry quota)

[erikchen, 2015-07-13 21:46:44]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-07-13 21:47:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1205713002/60001

[commit-bot: I haz the power, 2015-07-13 22:37:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-13 22:37:17]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[erikchen, 2015-07-14 21:43:23]

tsepez: Please review.

The only relevant change since patch set 4 is the addition of IPC_EXPORT to
ipc/attachment_broker_messages.h so that the message classes can be used by unit
tests.

[Tom Sepez, 2015-07-14 21:52:35]

lgtm

[erikchen, 2015-07-14 21:56:10]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2015-07-14 21:56:11]

The patchset sent to the CQ was uploaded after l-g-t-m from avi@chromium.org
Link to the patchset: https://codereview.chromium.org/1205713002/#ps100001
(title: "Update copyright date.")

[commit-bot: I haz the power, 2015-07-14 21:58:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1205713002/100001

[commit-bot: I haz the power, 2015-07-14 22:18:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-14 22:18:41]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[erikchen, 2015-07-14 23:04:51]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2015-07-14 23:05:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1205713002/100001

[commit-bot: I haz the power, 2015-07-15 01:35:49]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-07-15 01:36:52]

Patchset 6 (id:??) landed as
https://crrev.com/7252aa363e57e6a621ee719f0137d5e827e90cec
Cr-Commit-Position: refs/heads/master@{#338798}