Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 1205703003: Add tracing for ContentLayerDelegate paintContents and DisplayItemList commit. (Closed)

Created:
4 years, 10 months ago by chrishtr
Modified:
4 years, 10 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add tracing for ContentLayerDelegate paintContents and DisplayItemList commit. BUG=503705 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197757

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M Source/platform/graphics/ContentLayerDelegate.cpp View 1 2 3 3 chunks +18 lines, -0 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemList.h View 2 chunks +4 lines, -1 line 0 comments Download
M Source/platform/graphics/paint/DisplayItemList.cpp View 4 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
chrishtr
4 years, 10 months ago (2015-06-23 22:49:38 UTC) #2
Xianzhu
https://codereview.chromium.org/1205703003/diff/20001/Source/platform/graphics/ContentLayerDelegate.cpp File Source/platform/graphics/ContentLayerDelegate.cpp (right): https://codereview.chromium.org/1205703003/diff/20001/Source/platform/graphics/ContentLayerDelegate.cpp#newcode63 Source/platform/graphics/ContentLayerDelegate.cpp:63: tracedValue->pushInteger(clip.y + clip.height); The third and fourth values of ...
4 years, 10 months ago (2015-06-23 22:58:55 UTC) #3
chrishtr
https://codereview.chromium.org/1205703003/diff/20001/Source/platform/graphics/ContentLayerDelegate.cpp File Source/platform/graphics/ContentLayerDelegate.cpp (right): https://codereview.chromium.org/1205703003/diff/20001/Source/platform/graphics/ContentLayerDelegate.cpp#newcode63 Source/platform/graphics/ContentLayerDelegate.cpp:63: tracedValue->pushInteger(clip.y + clip.height); On 2015/06/23 at 22:58:54, Xianzhu wrote: ...
4 years, 10 months ago (2015-06-23 23:05:38 UTC) #4
Xianzhu
lgtm
4 years, 10 months ago (2015-06-23 23:08:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205703003/40001
4 years, 10 months ago (2015-06-23 23:08:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60445)
4 years, 10 months ago (2015-06-24 00:04:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205703003/40001
4 years, 10 months ago (2015-06-24 00:16:07 UTC) #11
commit-bot: I haz the power
Exceeded global retry quota
4 years, 10 months ago (2015-06-24 00:50:11 UTC) #13
Ken Russell (switch to Gerrit)
On 2015/06/24 00:50:11, commit-bot: I haz the power wrote: > Exceeded global retry quota I ...
4 years, 10 months ago (2015-06-24 01:37:43 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205703003/60001
4 years, 10 months ago (2015-06-24 16:33:42 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 16:37:37 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197757

Powered by Google App Engine
This is Rietveld 408576698