Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1205683002: Fixed leaking data in WebThreadSafeData (Closed)

Created:
5 years, 6 months ago by dmurph
Modified:
5 years, 6 months ago
Reviewers:
michaeln, pdr.
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fixed leaking data in WebThreadSafeData BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197765

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fixed other constructor #

Patch Set 3 : fixed other ctr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/platform/exported/WebThreadSafeData.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
dmurph
5 years, 6 months ago (2015-06-23 20:47:11 UTC) #2
michaeln
https://codereview.chromium.org/1205683002/diff/1/Source/platform/exported/WebThreadSafeData.cpp File Source/platform/exported/WebThreadSafeData.cpp (right): https://codereview.chromium.org/1205683002/diff/1/Source/platform/exported/WebThreadSafeData.cpp#newcode69 Source/platform/exported/WebThreadSafeData.cpp:69: : m_private(data.leakRef()) What about this one?
5 years, 6 months ago (2015-06-23 21:04:54 UTC) #3
dmurph
Hey, I made a mistake in my last CL and the new constructor leaks data ...
5 years, 6 months ago (2015-06-23 21:31:14 UTC) #5
michaeln
https://codereview.chromium.org/1205683002/diff/1/Source/platform/exported/WebThreadSafeData.cpp File Source/platform/exported/WebThreadSafeData.cpp (right): https://codereview.chromium.org/1205683002/diff/1/Source/platform/exported/WebThreadSafeData.cpp#newcode69 Source/platform/exported/WebThreadSafeData.cpp:69: : m_private(data.leakRef()) On 2015/06/23 21:04:53, michaeln wrote: > What ...
5 years, 6 months ago (2015-06-23 22:43:07 UTC) #6
dmurph
https://codereview.chromium.org/1205683002/diff/1/Source/platform/exported/WebThreadSafeData.cpp File Source/platform/exported/WebThreadSafeData.cpp (right): https://codereview.chromium.org/1205683002/diff/1/Source/platform/exported/WebThreadSafeData.cpp#newcode69 Source/platform/exported/WebThreadSafeData.cpp:69: : m_private(data.leakRef()) On 2015/06/23 at 22:43:07, michaeln wrote: > ...
5 years, 6 months ago (2015-06-24 00:06:11 UTC) #7
michaeln
lgtm!
5 years, 6 months ago (2015-06-24 01:25:43 UTC) #8
pdr.
On 2015/06/24 at 01:25:43, michaeln wrote: > lgtm! LGTM
5 years, 6 months ago (2015-06-24 17:49:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205683002/40001
5 years, 6 months ago (2015-06-24 17:51:11 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 18:50:15 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197765

Powered by Google App Engine
This is Rietveld 408576698