Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: tools/auto_bisect/bisect_printer.py

Issue 1205663002: Make bisect to abort early when the return codes for known good and known bad revisions are same. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/auto_bisect/bisect_printer.py
diff --git a/tools/auto_bisect/bisect_printer.py b/tools/auto_bisect/bisect_printer.py
index f23d662d495b90a67e33fc7e702f3ad1168ff853..9b92320b8e05d41f0ca8588ad87a0e82a6d2faf2 100644
--- a/tools/auto_bisect/bisect_printer.py
+++ b/tools/auto_bisect/bisect_printer.py
@@ -124,14 +124,21 @@ class BisectPrinter(object):
last_broken_rev, 100, final_step=False)
def _PrintAbortResults(self, abort_reason):
-
if self.opts.output_buildbot_annotations:
bisect_utils.OutputAnnotationStepStart('Results')
+
+ # Metric string in config is not split in case of return code mode.
+ if (self.opts.metric and
+ self.opts.bisect_mode != bisect_utils.BISECT_MODE_RETURN_CODE):
+ metric = '/'.join(self.opts.metric)
+ else:
+ metric = self.opts.metric
+
print ABORT_REASON_TEMPLATE % {
'abort_reason': abort_reason,
'bug_id': self.opts.bug_id or 'NOT SPECIFIED',
'command': self.opts.command,
- 'metric': '/'.join(self.opts.metric),
+ 'metric': metric,
'good_revision': self.opts.good_revision,
'bad_revision': self.opts.bad_revision,
}

Powered by Google App Engine
This is Rietveld 408576698