Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/auto_bisect/bisect_perf_regression.py

Issue 1205663002: Make bisect to abort early when the return codes for known good and known bad revisions are same. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/auto_bisect/bisect_perf_regression.py
diff --git a/tools/auto_bisect/bisect_perf_regression.py b/tools/auto_bisect/bisect_perf_regression.py
index ca97d67e422649087a3561debd89bdb8f94d169c..41db6ae00ba959a7afcbea7fc901098ec4e11b70 100755
--- a/tools/auto_bisect/bisect_perf_regression.py
+++ b/tools/auto_bisect/bisect_perf_regression.py
@@ -2307,9 +2307,18 @@ class BisectPerformanceMetrics(object):
# We need these reference values to determine if later runs should be
# classified as pass or fail.
+
known_bad_value = bad_results[0]
known_good_value = good_results[0]
+ # Abort bisect early when the return codes for known good
+ # and known bad revisions are same.
+ if (self._IsBisectModeReturnCode() and
+ known_bad_value['mean'] == known_good_value['mean']):
+ return BisectResults(abort_reason=('known good and known bad revisions '
+ 'returned same return code (return code=%s). '
+ 'Continuing bisect might not yield any results.' %
+ known_bad_value['mean']))
# Check the direction of improvement only if the improvement_direction
# option is set to a specific direction (1 for higher is better or -1 for
# lower is better).
« no previous file with comments | « no previous file | tools/auto_bisect/bisect_perf_regression_test.py » ('j') | tools/auto_bisect/bisect_perf_regression_test.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698