Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1205643002: Make SkGpuDevice know its alpha type (Closed)

Created:
5 years, 6 months ago by bsalomon
Modified:
5 years, 6 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkGpuDevice know its alpha type Make SkImage_Gpu snapshots opaque if surface is opaque. BUG=skia:3965 Committed: https://skia.googlesource.com/skia/+/74f681dce2fbadd481596aea15afb3e0fb36ceff

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : extra \n #

Total comments: 15

Patch Set 4 : address comments #

Patch Set 5 : Address comments #

Patch Set 6 : revert accidental file change #

Patch Set 7 : fix bench pictures :( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -67 lines) Patch
M include/gpu/GrSurface.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrLayerHoister.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrSurface.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrSurfacePriv.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 2 3 3 chunks +15 lines, -5 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 10 chunks +63 lines, -27 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 3 chunks +5 lines, -3 lines 0 comments Download
M tests/ImageFilterTest.cpp View 4 chunks +8 lines, -4 lines 0 comments Download
M tests/PremulAlphaRoundTripTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/ReadWriteAlphaTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/SurfaceTest.cpp View 1 2 3 4 11 chunks +48 lines, -17 lines 0 comments Download
M tools/PictureRenderer.cpp View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
bsalomon
5 years, 6 months ago (2015-06-23 19:25:25 UTC) #2
robertphillips
lgtm + questions & doc suggestions https://codereview.chromium.org/1205643002/diff/40001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/1205643002/diff/40001/src/gpu/SkGpuDevice.cpp#newcode137 src/gpu/SkGpuDevice.cpp:137: default: // If ...
5 years, 6 months ago (2015-06-23 19:48:10 UTC) #3
reed1
yeh https://codereview.chromium.org/1205643002/diff/40001/src/gpu/SkGpuDevice.h File src/gpu/SkGpuDevice.h (right): https://codereview.chromium.org/1205643002/diff/40001/src/gpu/SkGpuDevice.h#newcode33 src/gpu/SkGpuDevice.h:33: enum InitContents { Boy oh boy, we should ...
5 years, 6 months ago (2015-06-23 20:05:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205643002/80001
5 years, 6 months ago (2015-06-23 20:44:42 UTC) #8
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-23 20:45:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205643002/100001
5 years, 6 months ago (2015-06-23 21:25:20 UTC) #13
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-23 21:26:20 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205643002/90014
5 years, 6 months ago (2015-06-23 21:33:17 UTC) #18
commit-bot: I haz the power
Committed patchset #7 (id:90014) as https://skia.googlesource.com/skia/+/74f681dce2fbadd481596aea15afb3e0fb36ceff
5 years, 6 months ago (2015-06-23 21:38:52 UTC) #19
bsalomon
5 years, 6 months ago (2015-06-25 21:47:18 UTC) #20
Message was sent while issue was closed. 
forgot to publish comments the other day

https://codereview.chromium.org/1205643002/diff/40001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/1205643002/diff/40001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:137: default:
On 2015/06/23 19:48:09, robertphillips wrote:
> // If it is unpremul or unknown don't try to render

Done.

https://codereview.chromium.org/1205643002/diff/40001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:172: 
On 2015/06/23 19:48:09, robertphillips wrote:
> Should we change the alpha type & flags first ?

Done.

https://codereview.chromium.org/1205643002/diff/40001/src/gpu/SkGpuDevice.cpp...
src/gpu/SkGpuDevice.cpp:194: SkImageInfo info =
rt->surfacePriv().info(at).makeWH(width, height);
On 2015/06/23 19:48:09, robertphillips wrote:
> Why do we need this ?

oops, needed before I added the param to info().

https://codereview.chromium.org/1205643002/diff/40001/src/gpu/SkGpuDevice.h
File src/gpu/SkGpuDevice.h (right):

https://codereview.chromium.org/1205643002/diff/40001/src/gpu/SkGpuDevice.h#n...
src/gpu/SkGpuDevice.h:163: };
On 2015/06/23 19:48:09, robertphillips wrote:
> Do we need the "SkGpuDevice::" here ?

Done.

https://codereview.chromium.org/1205643002/diff/40001/tests/SurfaceTest.cpp
File tests/SurfaceTest.cpp (right):

https://codereview.chromium.org/1205643002/diff/40001/tests/SurfaceTest.cpp#n...
tests/SurfaceTest.cpp:42: 
On 2015/06/23 19:48:09, robertphillips wrote:
> create_surface ?

Done.

https://codereview.chromium.org/1205643002/diff/40001/tests/SurfaceTest.cpp#n...
tests/SurfaceTest.cpp:424: SkAutoTUnref<SkSurface>
surface(createSurface(gRec[i].fType, context,
On 2015/06/23 19:48:09, robertphillips wrote:
> tab over ?

Done.

https://codereview.chromium.org/1205643002/diff/40001/tests/SurfaceTest.cpp#n...
tests/SurfaceTest.cpp:491: SkAutoTUnref<SkSurface>
surface(createSurface(gRec[j].fType, context,
On 2015/06/23 19:48:09, robertphillips wrote:
> tab over ?

Done.

Powered by Google App Engine
This is Rietveld 408576698