Issue 1205623002: Make sky_tool work again after mojom package

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1205623002: Make sky_tool work again after mojom package (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
Cutch

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Make sky_tool work again after mojom package We now have to run mojom/lib/generate.dart before we can launch a sky app. :( Fixes https://github.com/domokit/mojo/issues/262 R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/432ce45f63a73ba43571491cb62797b0036f4ae2

Patch Set 1 #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -17 lines)			Patch
	M	sky/sdk/lib/sky_tool	View		5 chunks	+40 lines, -17 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Cutch

LGTM https://codereview.chromium.org/1205623002/diff/1/sky/sdk/lib/sky_tool File sky/sdk/lib/sky_tool (right): https://codereview.chromium.org/1205623002/diff/1/sky/sdk/lib/sky_tool#newcode28 sky/sdk/lib/sky_tool:28: DART_PATH = 'dart' We probably will need to ...

5 years, 6 months ago (2015-06-23 18:29:47 UTC) #2

eseidel

5 years, 6 months ago (2015-06-23 18:31:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
432ce45f63a73ba43571491cb62797b0036f4ae2 (presubmit successful).

Expand Messages | Collapse Messages