components/history/core/browser/history_service.cc - Issue 1205603002: Remove dependency of HistoryServiceFactory on ChromeBookmarkClientFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/browser/history_service.cc

Issue 1205603002: Remove dependency of HistoryServiceFactory on ChromeBookmarkClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_history_client

Patch Set: Fix unit_tests on android (only register as BookmarkModelObserver if HistoryService is initialized) Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/history/core/browser/history_client.h ('k') | components/history/core/test/history_client_fake_bookmarks.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/history/core/browser/history_service.cc

diff --git a/components/history/core/browser/history_service.cc b/components/history/core/browser/history_service.cc

index da0ed64137e740b8f4b79894060d797b5ffa0d98..cbac0309a9faea77a9b0b844855950c8f252b643 100644

--- a/components/history/core/browser/history_service.cc

+++ b/components/history/core/browser/history_service.cc

@@ -889,6 +889,9 @@ bool HistoryService::Init(

if (visit_delegate_ && !visit_delegate_->Init(this))

return false;

+ if (history_client_)

+ history_client_->OnHistoryServiceCreated(this);

return true;

}

« no previous file with comments | « components/history/core/browser/history_client.h ('k') | components/history/core/test/history_client_fake_bookmarks.h » ('j') | no next file with comments »