Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: components/history/core/browser/history_client.h

Issue 1205603002: Remove dependency of HistoryServiceFactory on ChromeBookmarkClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_history_client
Patch Set: Fix unit_tests on android (only register as BookmarkModelObserver if HistoryService is initialized) Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_client.h
diff --git a/components/history/core/browser/history_client.h b/components/history/core/browser/history_client.h
index ae9c19562e2fc0bde101137654331c79a8b88edc..27e04140ee63e662254ff2d4da7f09491b7c2fba 100644
--- a/components/history/core/browser/history_client.h
+++ b/components/history/core/browser/history_client.h
@@ -20,6 +20,7 @@ namespace history {
class HistoryBackend;
class HistoryBackendClient;
class HistoryDatabase;
+class HistoryService;
class ThumbnailDatabase;
// This class abstracts operations that depend on the embedder's environment,
@@ -29,6 +30,9 @@ class HistoryClient {
HistoryClient() {}
virtual ~HistoryClient() {}
+ // Called upon HistoryService creation.
+ virtual void OnHistoryServiceCreated(HistoryService* history_service) = 0;
+
// Called before HistoryService is shutdown.
virtual void Shutdown() = 0;
« no previous file with comments | « chrome/browser/history/history_service_factory.cc ('k') | components/history/core/browser/history_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698