Chromium Code Reviews Chromium Code Reviews
Issue 1205603002:
Remove dependency of HistoryServiceFactory on ChromeBookmarkClientFactory (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@split_history_client| Index: components/bookmarks/browser/bookmark_model_observer.h |
| diff --git a/components/bookmarks/browser/bookmark_model_observer.h b/components/bookmarks/browser/bookmark_model_observer.h |
| index a946d532ac8cdcf21053944e7d0b9e3d7bbea994..a05c8db659685231c0beac96417f2958637a3952 100644 |
| --- a/components/bookmarks/browser/bookmark_model_observer.h |
| +++ b/components/bookmarks/browser/bookmark_model_observer.h |
| @@ -20,7 +20,7 @@ class BookmarkModelObserver { |
| // Invoked when the model has finished loading. |ids_reassigned| mirrors |
| // that of BookmarkLoadDetails::ids_reassigned. See it for details. |
| virtual void BookmarkModelLoaded(BookmarkModel* model, |
| - bool ids_reassigned) = 0; |
| + bool ids_reassigned) {} |
| // Invoked from the destructor of the BookmarkModel. |
| virtual void BookmarkModelBeingDeleted(BookmarkModel* model) {} |
| @@ -30,12 +30,12 @@ class BookmarkModelObserver { |
| const BookmarkNode* old_parent, |
| int old_index, |
| const BookmarkNode* new_parent, |
| - int new_index) = 0; |
| + int new_index) {} |
| // Invoked when a node has been added. |
| virtual void BookmarkNodeAdded(BookmarkModel* model, |
| const BookmarkNode* parent, |
| - int index) = 0; |
| + int index) {} |
| // Invoked prior to removing a node from the model. When a node is removed |
| // it's descendants are implicitly removed from the model as |
| @@ -68,7 +68,7 @@ class BookmarkModelObserver { |
| const BookmarkNode* parent, |
| int old_index, |
| const BookmarkNode* node, |
| - const std::set<GURL>& no_longer_bookmarked) = 0; |
| + const std::set<GURL>& no_longer_bookmarked) {} |
| // Invoked before the title or url of a node is changed. |
| virtual void OnWillChangeBookmarkNode(BookmarkModel* model, |
| @@ -76,7 +76,7 @@ class BookmarkModelObserver { |
| // Invoked when the title or url of a node changes. |
| virtual void BookmarkNodeChanged(BookmarkModel* model, |
| - const BookmarkNode* node) = 0; |
| + const BookmarkNode* node) {} |
| // Invoked before the metainfo of a node is changed. |
| virtual void OnWillChangeBookmarkMetaInfo(BookmarkModel* model, |
| @@ -88,7 +88,7 @@ class BookmarkModelObserver { |
| // Invoked when a favicon has been loaded or changed. |
| virtual void BookmarkNodeFaviconChanged(BookmarkModel* model, |
| - const BookmarkNode* node) = 0; |
| + const BookmarkNode* node) {} |
| // Invoked before the direct children of |node| have been reordered in some |
| // way, such as sorted. |
| @@ -98,7 +98,7 @@ class BookmarkModelObserver { |
| // Invoked when the children (just direct children, not descendants) of |
| // |node| have been reordered in some way, such as sorted. |
| virtual void BookmarkNodeChildrenReordered(BookmarkModel* model, |
| - const BookmarkNode* node) = 0; |
| + const BookmarkNode* node) {} |
| // Invoked before an extensive set of model changes is about to begin. |
| // This tells UI intensive observers to wait until the updates finish to |
| @@ -123,7 +123,7 @@ class BookmarkModelObserver { |
| // bookmarks associated with them. |
| virtual void BookmarkAllUserNodesRemoved( |
| BookmarkModel* model, |
| - const std::set<GURL>& removed_urls) = 0; |
|
sky
2015/06/23 16:43:42
The idea with these functions is the one that may
sdefresne
2015/06/23 17:10:21
OK. I've removed the changes to BookmarkModelObser
|
| + const std::set<GURL>& removed_urls) {} |
| // Invoked before a set of model changes that is initiated by a single user |
| // action. For example, this is called a single time when pasting from the |
