Source/modules/webgl/WebGLFramebuffer.cpp - Issue 1205573003: WebGL 2: validate read buffer attachment when reading from FBO

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webgl/WebGLFramebuffer.cpp

Issue 1205573003: WebGL 2: validate read buffer attachment when reading from FBO (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed kbr's feedback: reading from framebuffer with GL_NONE is invalid Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webgl/WebGLFramebuffer.cpp

diff --git a/Source/modules/webgl/WebGLFramebuffer.cpp b/Source/modules/webgl/WebGLFramebuffer.cpp

index e0faf37fb3b4ba791212f297d59ae5c4e486544b..c16ca909715a9d0b5f480166b896975dcb4f9ce9 100644

--- a/Source/modules/webgl/WebGLFramebuffer.cpp

+++ b/Source/modules/webgl/WebGLFramebuffer.cpp

@@ -279,6 +279,7 @@ WebGLFramebuffer::WebGLFramebuffer(WebGLRenderingContextBase* ctx)

: WebGLContextObject(ctx)

, m_object(ctx->webContext()->createFramebuffer())

, m_hasEverBeenBound(false)

+ , m_readBuffer(GL_COLOR_ATTACHMENT0)

{

}

« no previous file with comments | « Source/modules/webgl/WebGLFramebuffer.h ('k') | Source/modules/webgl/WebGLRenderingContextBase.h » ('j') | no next file with comments »