Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: Source/core/events/DOMWindowEventQueue.cpp

Issue 1205573002: Oilpan: promptly finalize remaining SuspendableTimers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/LocalDOMWindow.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/events/DOMWindowEventQueue.cpp
diff --git a/Source/core/events/DOMWindowEventQueue.cpp b/Source/core/events/DOMWindowEventQueue.cpp
index c8e43a63e237d1bb527aef19f9324509294b339b..34cdcee58912935fea4debf735606e007bbc747e 100644
--- a/Source/core/events/DOMWindowEventQueue.cpp
+++ b/Source/core/events/DOMWindowEventQueue.cpp
@@ -40,7 +40,13 @@ class DOMWindowEventQueueTimer final : public NoBaseWillBeGarbageCollectedFinali
public:
DOMWindowEventQueueTimer(DOMWindowEventQueue* eventQueue, ExecutionContext* context)
: SuspendableTimer(context)
- , m_eventQueue(eventQueue) { }
+ , m_eventQueue(eventQueue)
+ {
+ }
+
+ // Eager finalization is needed to promptly stop this timer object.
+ // (see DOMTimer comment for more.)
+ EAGERLY_FINALIZE();
DEFINE_INLINE_VIRTUAL_TRACE()
{
visitor->trace(m_eventQueue);
« no previous file with comments | « no previous file | Source/core/frame/LocalDOMWindow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698