Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 1205573002: Oilpan: promptly finalize remaining SuspendableTimers. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: promptly finalize remaining SuspendableTimers. DOMWindowEventQueue and PostMessageTimer also need to promptly stop their timer upon being deemed garbage. R=haraken BUG=491488 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M Source/core/events/DOMWindowEventQueue.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
4 years, 10 months ago (2015-06-23 07:09:00 UTC) #2
haraken
LGTM
4 years, 10 months ago (2015-06-23 08:05:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205573002/1
4 years, 10 months ago (2015-06-23 15:25:58 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 16:29:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197659

Powered by Google App Engine
This is Rietveld 408576698