app_list: Fix SearchResultView result_ usage.

app_list: Fix SearchResultView result_ usage.

SearchResultView's |result_| could be NULL and should be handled properly.

BUG=332012
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243602

[Matt Giuca, 2014-01-07 22:55:07]

lgtm

https://codereview.chromium.org/120553004/diff/20003/ui/app_list/views/search...
File ui/app_list/views/search_result_view.cc (right):

https://codereview.chromium.org/120553004/diff/20003/ui/app_list/views/search...
ui/app_list/views/search_result_view.cc:334: ui::MenuModel* menu_model = result_
? result_->GetContextMenuModel() : NULL;
Optional nit: It seems a little weird in the NULL case that it says:

menu_model = NULL
if (!menu_model)
  return;

Maybe more readable (if a little more verbose) like this:

if (!result_)
  return;
ui::MenuModel* menu_model = result_->GetContextMenuModel();
if (!menu_model)
  return;

[xiyuan, 2014-01-07 23:12:44]

https://codereview.chromium.org/120553004/diff/20003/ui/app_list/views/search...
File ui/app_list/views/search_result_view.cc (right):

https://codereview.chromium.org/120553004/diff/20003/ui/app_list/views/search...
ui/app_list/views/search_result_view.cc:334: ui::MenuModel* menu_model = result_
? result_->GetContextMenuModel() : NULL;
On 2014/01/07 22:55:08, Matt Giuca wrote:
> Optional nit: It seems a little weird in the NULL case that it says:
> 
> menu_model = NULL
> if (!menu_model)
>   return;
> 
> Maybe more readable (if a little more verbose) like this:
> 
> if (!result_)
>   return;
> ui::MenuModel* menu_model = result_->GetContextMenuModel();
> if (!menu_model)
>   return;

Done.

[commit-bot: I haz the power, 2014-01-07 23:17:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/120553004/70001

[commit-bot: I haz the power, 2014-01-08 01:27:30]

Retried try job too often on win_rel for step(s) nacl_integration
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-08 17:06:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/120553004/70001

[commit-bot: I haz the power, 2014-01-08 18:21:28]

Change committed as 243602