Issue 120553003: NoSaveLayerCanvas now its own file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 120553003: NoSaveLayerCanvas now its own file (Closed)

Created:
6 years, 11 months ago by robertphillips

Modified:
6 years, 11 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This was already duplicated in lazy_pixel_ref_utils.cc and I was about to add another copy for SkGatherPixelRefsAndRects so I figured it was time it became a grown up class.

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -41 lines)			Patch
M	gyp/utils.gyp	View	1 chunk	+1 line, -0 lines	1 comment	Download
A	src/utils/SkNoSaveLayerCanvas.h	View	1 chunk	+60 lines, -0 lines	0 comments	Download
M	src/utils/SkPictureUtils.cpp	View	4 chunks	+3 lines, -41 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

6 years, 11 months ago (2014-01-07 18:58:09 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/120553003/diff/1/gyp/utils.gyp
File gyp/utils.gyp (right):

https://codereview.chromium.org/120553003/diff/1/gyp/utils.gyp#newcode50
gyp/utils.gyp:50: '../include/utils/SkNoSaveLayerCanvas.h',
This file is in 'src', not 'include'?

Expand Messages | Collapse Messages