Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1205493005: Service Worker: Add initialization step for getRegistrations.html layout test. (Closed)

Created:
5 years, 6 months ago by jungkees
Modified:
5 years, 6 months ago
CC:
blink-reviews, michaeln, jsbell, tzik, serviceworker-reviews, nhiroki, dglazkov+blink, kinuko+serviceworker, horo
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Service Worker: Add initialization step for getRegistrations.html layout test. Add an initialization test that unregisters all the existing registrations in the origin before getRegistrations() are being tested so this test is not affected by other tests. BUG=502125 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197625

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M LayoutTests/http/tests/serviceworker/getregistrations.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/multiple-register.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
jungkees
This CL resolves the issue that getRegistrations() test is affected by other test files as ...
5 years, 6 months ago (2015-06-23 01:48:30 UTC) #2
lgombos
peer review looks good to me
5 years, 6 months ago (2015-06-23 01:54:20 UTC) #3
jungkees
PTAL
5 years, 6 months ago (2015-06-23 01:58:39 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205493005/1
5 years, 6 months ago (2015-06-23 01:59:52 UTC) #7
falken
lgtm https://codereview.chromium.org/1205493005/diff/1/LayoutTests/http/tests/serviceworker/getregistrations.html File LayoutTests/http/tests/serviceworker/getregistrations.html (right): https://codereview.chromium.org/1205493005/diff/1/LayoutTests/http/tests/serviceworker/getregistrations.html#newcode15 LayoutTests/http/tests/serviceworker/getregistrations.html:15: return registrations.reduce(function(sequence, registration) { nit: you'll have to ...
5 years, 6 months ago (2015-06-23 02:19:46 UTC) #8
jungkees
Corrected. Thanks. https://codereview.chromium.org/1205493005/diff/1/LayoutTests/http/tests/serviceworker/getregistrations.html File LayoutTests/http/tests/serviceworker/getregistrations.html (right): https://codereview.chromium.org/1205493005/diff/1/LayoutTests/http/tests/serviceworker/getregistrations.html#newcode15 LayoutTests/http/tests/serviceworker/getregistrations.html:15: return registrations.reduce(function(sequence, registration) { Oh, the file ...
5 years, 6 months ago (2015-06-23 02:30:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205493005/20001
5 years, 6 months ago (2015-06-23 02:32:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60204)
5 years, 6 months ago (2015-06-23 03:59:08 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205493005/20001
5 years, 6 months ago (2015-06-23 04:22:35 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-23 04:50:49 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197625

Powered by Google App Engine
This is Rietveld 408576698