cc: Remove unnecessary task runner refptrs from schedulers.

cc: Remove unnecessary task runner refptrs from schedulers.

Task runners are ref counted so that they can be used safely from
multiple threads. This is not required for (Display)Scheduler in which
case the owner of the scheduler (Proxy or OnScreenDisplayClient) holds
a reference to the task runner for as long as the scheduler lives.

R=brianderson,mithro
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/86c1dbcdd76224d456d1a67302c31f89b082c464
Cr-Commit-Position: refs/heads/master@{#335817}

[sunnyps, 2015-06-22 23:43:22]

PTAL

[mithro-old, 2015-06-22 23:50:11]

The CQ bit was checked by mithro@mithis.com

[mithro-old, 2015-06-22 23:50:12]

lgtm

[commit-bot: I haz the power, 2015-06-22 23:51:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1205483004/1

[commit-bot: I haz the power, 2015-06-22 23:55:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-22 23:55:48]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sunnyps, 2015-06-23 00:02:37]

This requires https://codereview.chromium.org/1201573002/ to go in first.

[mithro-old, 2015-06-23 00:03:43]

On 2015/06/23 00:02:37, sunnyps wrote:
> This requires https://codereview.chromium.org/1201573002/ to go in first.

With the commit queue could handle that. I'll send it to the commit queue once
the other one lands later today.

Tim

[sunnyps, 2015-06-23 01:58:06]

The CQ bit was checked by sunnyps@chromium.org

[commit-bot: I haz the power, 2015-06-23 01:58:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1205483004/1

[commit-bot: I haz the power, 2015-06-23 02:27:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 02:27:28]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[mithro-old, 2015-06-23 02:35:29]

On 2015/06/23 02:27:28, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

The bots still need a little longer to pick up the other patch :(

Tim

[mithro-old, 2015-06-23 02:57:55]

The CQ bit was checked by mithro@mithis.com

[commit-bot: I haz the power, 2015-06-23 02:58:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1205483004/1

[commit-bot: I haz the power, 2015-06-23 03:13:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 03:13:17]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[mithro-old, 2015-06-23 03:14:25]

On 2015/06/23 02:57:55, mithro wrote:
> The CQ bit was checked by mailto:mithro@mithis.com

[1058/2407] CXX obj/content/browser/media/browser.media_web_contents_observer.o
FAILED: /b/build/goma/gomacc
../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++
-MMD -MF obj/components/view_manager/surfaces/lib.surfaces_scheduler.o.d
-DV8_DEPRECATION_WARNINGS -DCLD_VERSION=1 -DENABLE_NOTIFICATIONS
-DENABLE_BROWSER_CDMS -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
-DDONT_EMBED_BUILD_METADATA -DDCHECK_ALWAYS_ON=1 -DUSE_OPENSSL=1
-DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DDISABLE_NACL -DENABLE_CONFIGURATION_POLICY
-DENABLE_SUPERVISED_USERS=1 -DENABLE_AUTOFILL_DIALOG=1 -DUSE_PROPRIETARY_CODECS
-DV8_USE_EXTERNAL_STARTUP_DATA -DVIDEO_HOLE=1 -DMOBILE_SAFE_BROWSING
-DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -DANDROID
-DHAVE_SYS_UIO_H -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
-D_FORTIFY_SOURCE=2 -D__GNU_SOURCE=1 -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -DMEDIA_DISABLE_LIBVPX -DMEDIA_DISABLE_FFMPEG
-DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1
-DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA -DU_USING_ICU_NAMESPACE=0
-DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DGLES2_USE_MOJO -I../.. -Igen
-I../../third_party/khronos -I../../gpu -I../../skia/config -I../../skia/ext
-I../../third_party/skia/include/c -I../../third_party/skia/include/config
-I../../third_party/skia/include/core -I../../third_party/skia/include/effects
-I../../third_party/skia/include/images -I../../third_party/skia/include/lazy
-I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu
-I../../third_party/skia/src/gpu -I../../third_party/mojo/src
-Igen/third_party/mojo/src -I../../third_party/icu/source/common
-I../../third_party/icu/source/i18n -fno-strict-aliasing -march=armv7-a
-mfloat-abi=softfp -mtune=generic-armv7-a -mthumb -mthumb-interwork
-fno-tree-sra -fno-caller-saves -funwind-tables -fPIC -pipe -ffunction-sections
-funwind-tables -fno-short-enums -finline-limit=64 -mfpu=vfpv3-d16 -Wall
-Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers
-Wno-unused-parameter -Wno-psabi -Wno-extra -Wno-ignored-qualifiers
-Wno-type-limits -Wno-unused-local-typedefs
-isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include
-isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include
-isystem../../third_party/android_tools/ndk/sources/android/support/include
-fvisibility=hidden
--sysroot=/b/build/slave/android_chromium_gn/build/src/third_party/android_tools/ndk/platforms/android-16/arch-arm
-Os -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g1
-fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing
-Wno-literal-suffix -Wno-error=c++0x-compat -Wno-non-virtual-dtor
-Wno-sign-promo -fno-rtti -fno-exceptions -c
../../components/view_manager/surfaces/surfaces_scheduler.cc -o
obj/components/view_manager/surfaces/lib.surfaces_scheduler.o
../../components/view_manager/surfaces/surfaces_scheduler.cc: In constructor
'surfaces::SurfacesScheduler::SurfacesScheduler()':
../../components/view_manager/surfaces/surfaces_scheduler.cc:14:78: error: no
matching function for call to
'cc::Scheduler::Create(surfaces::SurfacesScheduler*, cc::SchedulerSettings&,
int, scoped_refptr<base::SingleThreadTaskRunner>, std::nullptr_t)'
       this, settings, 0, base::MessageLoop::current()->task_runner(), nullptr);
                                                                              ^
../../components/view_manager/surfaces/surfaces_scheduler.cc:14:78: note:
candidate is:
In file included from
../../components/view_manager/surfaces/surfaces_scheduler.h:10:0,
                 from
../../components/view_manager/surfaces/surfaces_scheduler.cc:5:
../../cc/scheduler/scheduler.h:58:32: note: static scoped_ptr<cc::Scheduler>
cc::Scheduler::Create(cc::SchedulerClient*, const cc::SchedulerSettings&, int,
base::SingleThreadTaskRunner*, cc::BeginFrameSource*)
   static scoped_ptr<Scheduler> Create(
                                ^
../../cc/scheduler/scheduler.h:58:32: note:   no known conversion for argument 4
from 'scoped_refptr<base::SingleThreadTaskRunner>' to
'base::SingleThreadTaskRunner*'
ninja: build stopped: subcommand failed.

[mithro-old, 2015-06-23 03:14:48]

On 2015/06/23 03:14:25, mithro wrote:
> On 2015/06/23 02:57:55, mithro wrote:
> > The CQ bit was checked by mailto:mithro@mithis.com
> 
> [1058/2407] CXX
obj/content/browser/media/browser.media_web_contents_observer.o
> FAILED: /b/build/goma/gomacc
>
../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++
> -MMD -MF obj/components/view_manager/surfaces/lib.surfaces_scheduler.o.d
> -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=1 -DENABLE_NOTIFICATIONS
> -DENABLE_BROWSER_CDMS -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
> -DDONT_EMBED_BUILD_METADATA -DDCHECK_ALWAYS_ON=1 -DUSE_OPENSSL=1
> -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DDISABLE_NACL
-DENABLE_CONFIGURATION_POLICY
> -DENABLE_SUPERVISED_USERS=1 -DENABLE_AUTOFILL_DIALOG=1
-DUSE_PROPRIETARY_CODECS
> -DV8_USE_EXTERNAL_STARTUP_DATA -DVIDEO_HOLE=1 -DMOBILE_SAFE_BROWSING
> -DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -DANDROID
> -DHAVE_SYS_UIO_H -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
> -D_FORTIFY_SOURCE=2 -D__GNU_SOURCE=1 -DNDEBUG -DNVALGRIND
> -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DMEDIA_DISABLE_LIBVPX -DMEDIA_DISABLE_FFMPEG
> -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1
> -DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA -DU_USING_ICU_NAMESPACE=0
> -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DGLES2_USE_MOJO -I../.. -Igen
> -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../skia/ext
> -I../../third_party/skia/include/c -I../../third_party/skia/include/config
> -I../../third_party/skia/include/core -I../../third_party/skia/include/effects
> -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy
> -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf
> -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
> -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu
> -I../../third_party/skia/src/gpu -I../../third_party/mojo/src
> -Igen/third_party/mojo/src -I../../third_party/icu/source/common
> -I../../third_party/icu/source/i18n -fno-strict-aliasing -march=armv7-a
> -mfloat-abi=softfp -mtune=generic-armv7-a -mthumb -mthumb-interwork
> -fno-tree-sra -fno-caller-saves -funwind-tables -fPIC -pipe
-ffunction-sections
> -funwind-tables -fno-short-enums -finline-limit=64 -mfpu=vfpv3-d16 -Wall
> -Wsign-compare -Wendif-labels -Werror -Wno-missing-field-initializers
> -Wno-unused-parameter -Wno-psabi -Wno-extra -Wno-ignored-qualifiers
> -Wno-type-limits -Wno-unused-local-typedefs
>
-isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include
>
-isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include
> -isystem../../third_party/android_tools/ndk/sources/android/support/include
> -fvisibility=hidden
>
--sysroot=/b/build/slave/android_chromium_gn/build/src/third_party/android_tools/ndk/platforms/android-16/arch-arm
> -Os -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g1
> -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11
-Wno-narrowing
> -Wno-literal-suffix -Wno-error=c++0x-compat -Wno-non-virtual-dtor
> -Wno-sign-promo -fno-rtti -fno-exceptions -c
> ../../components/view_manager/surfaces/surfaces_scheduler.cc -o
> obj/components/view_manager/surfaces/lib.surfaces_scheduler.o
> ../../components/view_manager/surfaces/surfaces_scheduler.cc: In constructor
> 'surfaces::SurfacesScheduler::SurfacesScheduler()':
> ../../components/view_manager/surfaces/surfaces_scheduler.cc:14:78: error: no
> matching function for call to
> 'cc::Scheduler::Create(surfaces::SurfacesScheduler*, cc::SchedulerSettings&,
> int, scoped_refptr<base::SingleThreadTaskRunner>, std::nullptr_t)'
>        this, settings, 0, base::MessageLoop::current()->task_runner(),
nullptr);
>                                                                              
^
> ../../components/view_manager/surfaces/surfaces_scheduler.cc:14:78: note:
> candidate is:
> In file included from
> ../../components/view_manager/surfaces/surfaces_scheduler.h:10:0,
>                  from
> ../../components/view_manager/surfaces/surfaces_scheduler.cc:5:
> ../../cc/scheduler/scheduler.h:58:32: note: static scoped_ptr<cc::Scheduler>
> cc::Scheduler::Create(cc::SchedulerClient*, const cc::SchedulerSettings&, int,
> base::SingleThreadTaskRunner*, cc::BeginFrameSource*)
>    static scoped_ptr<Scheduler> Create(
>                                 ^
> ../../cc/scheduler/scheduler.h:58:32: note:   no known conversion for argument
4
> from 'scoped_refptr<base::SingleThreadTaskRunner>' to
> 'base::SingleThreadTaskRunner*'
> ninja: build stopped: subcommand failed.

http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...

[sunnyps, 2015-06-23 20:39:34]

sunnyps@chromium.org changed reviewers:
+ sky@chromium.org

[sunnyps, 2015-06-23 20:39:35]

+sky for surfaces_scheduler review

[sky, 2015-06-23 21:48:21]

LGTM

[sunnyps, 2015-06-23 22:41:16]

The CQ bit was checked by sunnyps@chromium.org

[sunnyps, 2015-06-23 22:41:16]

The patchset sent to the CQ was uploaded after l-g-t-m from mithro@mithis.com
Link to the patchset: https://codereview.chromium.org/1205483004/#ps20001
(title: "fix surfaces_scheduler compile error")

[commit-bot: I haz the power, 2015-06-23 22:42:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1205483004/20001

[commit-bot: I haz the power, 2015-06-24 00:10:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-24 00:11:15]

Patchset 2 (id:??) landed as
https://crrev.com/86c1dbcdd76224d456d1a67302c31f89b082c464
Cr-Commit-Position: refs/heads/master@{#335817}