chrome/browser/component_updater/pnacl/pnacl_component_installer.cc - Issue 12054003: Add an API to component_updater that asks to do an update check "now".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/pnacl/pnacl_component_installer.cc

Issue 12054003: Add an API to component_updater that asks to do an update check "now". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/component_updater/component_updater_service.h ('K') | « chrome/browser/component_updater/component_updater_service.cc ('k') | chrome/browser/component_updater/test/component_updater_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/component_updater/pnacl/pnacl_component_installer.cc

diff --git a/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc b/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc

index e33c21b43754956d9aa1bc4c2acbfad00a5ca236..6f96a85fb3f3a8e8590e90dca3094bc991520ca3 100644

--- a/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc

+++ b/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc

@@ -69,10 +69,6 @@ const char* PnaclArch() {

}

// If we don't have Pnacl installed, this is the version we claim.

-// TODO(jvoung): Is there a way to trick the configurator to ping the server

-// earlier if there are components that are not yet installed (version 0.0.0.0),

-// So that they will be available ASAP? Be careful not to hurt startup speed.

-// Make kNullVersion part of ComponentUpdater in that case, to avoid skew?

const char kNullVersion[] = "0.0.0.0";

// Pnacl components have the version encoded in the path itself: