Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 120533002: add system libXNVCtrl library support in linux unbundle (Closed)

Created:
7 years ago by Elan Ruusamäe
Modified:
6 years, 10 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

add system libXNVCtrl library support in linux unbundle originally developed here: https://github.com/pld-linux/chromium-browser/commits/ea209591465e59e433cbb231270088a3d45658a2/system-libxnvctrl.patch reviewed by phajdan.jr in private mail exchange R=phajdan.jr@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250495

Patch Set 1 #

Patch Set 2 : Changed author to gmail address #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
A + build/linux/unbundle/libXNVCtrl.gyp View 1 chunk +15 lines, -18 lines 0 comments Download
M build/linux/unbundle/replace_gyp_files.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Elan Ruusamäe
7 years ago (2013-12-22 12:29:43 UTC) #1
Elan Ruusamäe
build/linux/unbundle/libXNVCtrl.gyp is new file, but the "View" shows like it was patched from zlib.gyp (based ...
7 years ago (2013-12-22 12:36:03 UTC) #2
Paweł Hajdan Jr.
LGTM, thanks!
6 years, 11 months ago (2014-01-02 12:30:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elan.ruusamae@gmail.com/120533002/1
6 years, 11 months ago (2014-01-03 13:44:14 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43152
6 years, 11 months ago (2014-01-03 13:58:45 UTC) #5
Elan Ruusamäe
The CQ bit was checked by elan.ruusamae@gmail.com
6 years, 10 months ago (2014-02-11 10:14:55 UTC) #6
Elan Ruusamäe
The CQ bit was unchecked by elan.ruusamae@gmail.com
6 years, 10 months ago (2014-02-11 10:14:56 UTC) #7
Elan Ruusamäe
The CQ bit was checked by elan.ruusamae@gmail.com
6 years, 10 months ago (2014-02-11 10:14:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elan.ruusamae@gmail.com/120533002/170001
6 years, 10 months ago (2014-02-11 10:15:03 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-11 10:50:46 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 10 months ago (2014-02-11 10:50:47 UTC) #11
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 10 months ago (2014-02-11 18:56:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elan.ruusamae@gmail.com/120533002/170001
6 years, 10 months ago (2014-02-11 19:00:34 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-11 20:53:45 UTC) #14
Message was sent while issue was closed.
Change committed as 250495

Powered by Google App Engine
This is Rietveld 408576698