compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java - Issue 12052084: Issue 8027. Disallow cyclic mixins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java

Issue 12052084: Issue 8027. Disallow cyclic mixins. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java ('k') | compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java b/compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java

index 6f137671438ad12785189f8fb8776de36347db8e..ed9505e4f11232bb344f78af9285cf8d5e468f4d 100644

--- a/compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java

+++ b/compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java

@@ -177,10 +177,6 @@ public class SupertypeResolver {

topLevelContext.onError(mixNode, ResolverErrorCode.SUPER_CLASS_IN_WITH);

continue;

}

- if (!Objects.equal(mixType.getElement().getSupertype(), typeProvider.getObjectType())) {

- topLevelContext.onError(mixNode, ResolverErrorCode.ONLY_OBJECT_MIXIN_SUPERCLASS);

- continue;

- }

seenMixin.add(mixType);

// OK, add

Elements.addMixin(classElement, mixType);