Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 12052076: Support overloaded constructors. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index f44afd146552ce267ea00d3b632645a75c37de58..34c0ca8e14d8ec2f6998e3a5b35317f6322658af 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -555,8 +555,10 @@ class ArrayBuffer extends NativeFieldWrapperClass1 {
ArrayBuffer.internal();
@DocsEditable
- factory ArrayBuffer(int length) => ArrayBuffer._create(length);
- static ArrayBuffer _create(int length) native "ArrayBuffer_constructor_Callback";
+ factory ArrayBuffer(int length) {
+ return ArrayBuffer._create_1(length);
+ }
+ static ArrayBuffer _create_1(length) native "ArrayBuffer_create_1_constructor_Callback";
/// Checks if this type is supported on the current platform.
static bool get supported => true;
@@ -637,12 +639,9 @@ class AudioElement extends MediaElement {
@DocsEditable
factory AudioElement([String src]) {
- if (!?src) {
- return AudioElement._create();
- }
- return AudioElement._create(src);
+ return AudioElement._create_1(src);
}
- static AudioElement _create([String src]) native "HTMLAudioElement_constructor_Callback";
+ static AudioElement _create_1(src) native "HTMLAudioElement_create_1_constructor_Callback";
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -836,15 +835,9 @@ class Blob extends NativeFieldWrapperClass1 {
@DocsEditable
factory Blob(List blobParts, [String type, String endings]) {
- if (!?type) {
- return Blob._create(blobParts);
- }
- if (!?endings) {
- return Blob._create(blobParts, type);
- }
- return Blob._create(blobParts, type, endings);
+ return Blob._create_1(blobParts, type, endings);
}
- static Blob _create(List blobParts, [String type, String endings]) native "Blob_constructor_Callback";
+ static Blob _create_1(blobParts, type, endings) native "Blob_create_1_constructor_Callback";
@DomName('Blob.size')
@DocsEditable
@@ -2381,12 +2374,9 @@ class CssMatrix extends NativeFieldWrapperClass1 {
@DocsEditable
factory CssMatrix([String cssValue]) {
- if (!?cssValue) {
- return CssMatrix._create();
- }
- return CssMatrix._create(cssValue);
+ return CssMatrix._create_1(cssValue);
}
- static CssMatrix _create([String cssValue]) native "WebKitCSSMatrix_constructor_Callback";
+ static CssMatrix _create_1(cssValue) native "WebKitCSSMatrix_create_1_constructor_Callback";
@DomName('WebKitCSSMatrix.a')
@DocsEditable
@@ -6394,15 +6384,9 @@ class DataView extends ArrayBufferView {
@DocsEditable
factory DataView(ArrayBuffer buffer, [int byteOffset, int byteLength]) {
- if (!?byteOffset) {
- return DataView._create(buffer);
- }
- if (!?byteLength) {
- return DataView._create(buffer, byteOffset);
- }
- return DataView._create(buffer, byteOffset, byteLength);
+ return DataView._create_1(buffer, byteOffset, byteLength);
}
- static DataView _create(ArrayBuffer buffer, [int byteOffset, int byteLength]) native "DataView_constructor_Callback";
+ static DataView _create_1(buffer, byteOffset, byteLength) native "DataView_create_1_constructor_Callback";
num getFloat32(int byteOffset, {bool littleEndian}) {
if (?littleEndian) {
@@ -7894,8 +7878,10 @@ class DomParser extends NativeFieldWrapperClass1 {
DomParser.internal();
@DocsEditable
- factory DomParser() => DomParser._create();
- static DomParser _create() native "DOMParser_constructor_Callback";
+ factory DomParser() {
+ return DomParser._create_1();
+ }
+ static DomParser _create_1() native "DOMParser_create_1_constructor_Callback";
@DomName('DOMParser.parseFromString')
@DocsEditable
@@ -10781,12 +10767,9 @@ class EventSource extends EventTarget {
@DocsEditable
factory EventSource(String url, [Map eventSourceInit]) {
- if (!?eventSourceInit) {
- return EventSource._create(url);
- }
- return EventSource._create(url, eventSourceInit);
+ return EventSource._create_1(url, eventSourceInit);
}
- static EventSource _create(String url, [Map eventSourceInit]) native "EventSource_constructor_Callback";
+ static EventSource _create_1(url, eventSourceInit) native "EventSource_create_1_constructor_Callback";
@DocsEditable
@DomName('EventTarget.addEventListener, EventTarget.removeEventListener, EventTarget.dispatchEvent')
@@ -11434,8 +11417,10 @@ class FileReader extends EventTarget {
static const EventStreamProvider<ProgressEvent> progressEvent = const EventStreamProvider<ProgressEvent>('progress');
@DocsEditable
- factory FileReader() => FileReader._create();
- static FileReader _create() native "FileReader_constructor_Callback";
+ factory FileReader() {
+ return FileReader._create_1();
+ }
+ static FileReader _create_1() native "FileReader_create_1_constructor_Callback";
@DocsEditable
@DomName('EventTarget.addEventListener, EventTarget.removeEventListener, EventTarget.dispatchEvent')
@@ -11569,8 +11554,10 @@ class FileReaderSync extends NativeFieldWrapperClass1 {
FileReaderSync.internal();
@DocsEditable
- factory FileReaderSync() => FileReaderSync._create();
- static FileReaderSync _create() native "FileReaderSync_constructor_Callback";
+ factory FileReaderSync() {
+ return FileReaderSync._create_1();
+ }
+ static FileReaderSync _create_1() native "FileReaderSync_create_1_constructor_Callback";
@DomName('FileReaderSync.readAsArrayBuffer')
@DocsEditable
@@ -12298,12 +12285,9 @@ class FormData extends NativeFieldWrapperClass1 {
@DocsEditable
factory FormData([FormElement form]) {
- if (!?form) {
- return FormData._create();
- }
- return FormData._create(form);
+ return FormData._create_1(form);
}
- static FormData _create([FormElement form]) native "DOMFormData_constructor_Callback";
+ static FormData _create_1(form) native "DOMFormData_create_1_constructor_Callback";
@DomName('DOMFormData.append')
@DocsEditable
@@ -13332,8 +13316,10 @@ class HttpRequest extends EventTarget {
static const EventStreamProvider<ProgressEvent> readyStateChangeEvent = const EventStreamProvider<ProgressEvent>('readystatechange');
@DocsEditable
- factory HttpRequest() => HttpRequest._create();
- static HttpRequest _create() native "XMLHttpRequest_constructor_Callback";
+ factory HttpRequest() {
+ return HttpRequest._create_1();
+ }
+ static HttpRequest _create_1() native "XMLHttpRequest_create_1_constructor_Callback";
@DocsEditable
@DomName('EventTarget.addEventListener, EventTarget.removeEventListener, EventTarget.dispatchEvent')
@@ -16167,8 +16153,10 @@ class MediaController extends EventTarget {
MediaController.internal() : super.internal();
@DocsEditable
- factory MediaController() => MediaController._create();
- static MediaController _create() native "MediaController_constructor_Callback";
+ factory MediaController() {
+ return MediaController._create_1();
+ }
+ static MediaController _create_1() native "MediaController_create_1_constructor_Callback";
@DomName('MediaController.buffered')
@DocsEditable
@@ -17035,8 +17023,10 @@ class MediaSource extends EventTarget {
MediaSource.internal() : super.internal();
@DocsEditable
- factory MediaSource() => MediaSource._create();
- static MediaSource _create() native "MediaSource_constructor_Callback";
+ factory MediaSource() {
+ return MediaSource._create_1();
+ }
+ static MediaSource _create_1() native "MediaSource_create_1_constructor_Callback";
@DomName('MediaSource.activeSourceBuffers')
@DocsEditable
@@ -17098,8 +17088,10 @@ class MediaStream extends EventTarget {
static const EventStreamProvider<Event> endedEvent = const EventStreamProvider<Event>('ended');
@DocsEditable
- factory MediaStream() => MediaStream._create();
- static MediaStream _create() native "MediaStream_constructor_Callback";
+ factory MediaStream() {
+ return MediaStream._create_1();
+ }
+ static MediaStream _create_1() native "MediaStream_create_1_constructor_Callback";
@DocsEditable
@DomName('EventTarget.addEventListener, EventTarget.removeEventListener, EventTarget.dispatchEvent')
@@ -17376,8 +17368,10 @@ class MessageChannel extends NativeFieldWrapperClass1 {
MessageChannel.internal();
@DocsEditable
- factory MessageChannel() => MessageChannel._create();
- static MessageChannel _create() native "MessageChannel_constructor_Callback";
+ factory MessageChannel() {
+ return MessageChannel._create_1();
+ }
+ static MessageChannel _create_1() native "MessageChannel_create_1_constructor_Callback";
@DomName('MessageChannel.port1')
@DocsEditable
@@ -17847,8 +17841,10 @@ class MutationObserver extends NativeFieldWrapperClass1 {
MutationObserver.internal();
@DocsEditable
- factory MutationObserver(MutationCallback callback) => MutationObserver._create(callback);
- static MutationObserver _create(MutationCallback callback) native "MutationObserver_constructor_Callback";
+ factory MutationObserver(MutationCallback callback) {
+ return MutationObserver._create_1(callback);
+ }
+ static MutationObserver _create_1(callback) native "MutationObserver_create_1_constructor_Callback";
@DomName('MutationObserver.disconnect')
@DocsEditable
@@ -19078,12 +19074,9 @@ class Notification extends EventTarget {
@DocsEditable
factory Notification(String title, [Map options]) {
- if (!?options) {
- return Notification._create(title);
- }
- return Notification._create(title, options);
+ return Notification._create_1(title, options);
}
- static Notification _create(String title, [Map options]) native "Notification_constructor_Callback";
+ static Notification _create_1(title, options) native "Notification_create_1_constructor_Callback";
@DocsEditable
@DomName('EventTarget.addEventListener, EventTarget.removeEventListener, EventTarget.dispatchEvent')
@@ -19493,21 +19486,9 @@ class OptionElement extends _Element_Merged {
@DocsEditable
factory OptionElement([String data, String value, bool defaultSelected, bool selected]) {
- if (!?data) {
- return OptionElement._create();
- }
- if (!?value) {
- return OptionElement._create(data);
- }
- if (!?defaultSelected) {
- return OptionElement._create(data, value);
- }
- if (!?selected) {
- return OptionElement._create(data, value, defaultSelected);
- }
- return OptionElement._create(data, value, defaultSelected, selected);
+ return OptionElement._create_1(data, value, defaultSelected, selected);
}
- static OptionElement _create([String data, String value, bool defaultSelected, bool selected]) native "HTMLOptionElement_constructor_Callback";
+ static OptionElement _create_1(data, value, defaultSelected, selected) native "HTMLOptionElement_create_1_constructor_Callback";
@DomName('HTMLOptionElement.defaultSelected')
@DocsEditable
@@ -19943,8 +19924,10 @@ class Point extends NativeFieldWrapperClass1 {
Point.internal();
@DocsEditable
- factory Point(num x, num y) => Point._create(x, y);
- static Point _create(num x, num y) native "WebKitPoint_constructor_Callback";
+ factory Point(num x, num y) {
+ return Point._create_1(x, y);
+ }
+ static Point _create_1(x, y) native "WebKitPoint_create_1_constructor_Callback";
@DomName('WebKitPoint.x')
@DocsEditable
@@ -20643,8 +20626,10 @@ class RtcIceCandidate extends NativeFieldWrapperClass1 {
RtcIceCandidate.internal();
@DocsEditable
- factory RtcIceCandidate(Map dictionary) => RtcIceCandidate._create(dictionary);
- static RtcIceCandidate _create(Map dictionary) native "RTCIceCandidate_constructor_Callback";
+ factory RtcIceCandidate(Map dictionary) {
+ return RtcIceCandidate._create_1(dictionary);
+ }
+ static RtcIceCandidate _create_1(dictionary) native "RTCIceCandidate_create_1_constructor_Callback";
@DomName('RTCIceCandidate.candidate')
@DocsEditable
@@ -20722,12 +20707,9 @@ class RtcPeerConnection extends EventTarget {
@DocsEditable
factory RtcPeerConnection(Map rtcIceServers, [Map mediaConstraints]) {
- if (!?mediaConstraints) {
- return RtcPeerConnection._create(rtcIceServers);
- }
- return RtcPeerConnection._create(rtcIceServers, mediaConstraints);
+ return RtcPeerConnection._create_1(rtcIceServers, mediaConstraints);
}
- static RtcPeerConnection _create(Map rtcIceServers, [Map mediaConstraints]) native "RTCPeerConnection_constructor_Callback";
+ static RtcPeerConnection _create_1(rtcIceServers, mediaConstraints) native "RTCPeerConnection_create_1_constructor_Callback";
@DocsEditable
@DomName('EventTarget.addEventListener, EventTarget.removeEventListener, EventTarget.dispatchEvent')
@@ -20893,8 +20875,10 @@ class RtcSessionDescription extends NativeFieldWrapperClass1 {
RtcSessionDescription.internal();
@DocsEditable
- factory RtcSessionDescription(Map dictionary) => RtcSessionDescription._create(dictionary);
- static RtcSessionDescription _create(Map dictionary) native "RTCSessionDescription_constructor_Callback";
+ factory RtcSessionDescription(Map dictionary) {
+ return RtcSessionDescription._create_1(dictionary);
+ }
+ static RtcSessionDescription _create_1(dictionary) native "RTCSessionDescription_create_1_constructor_Callback";
@DomName('RTCSessionDescription.sdp')
@DocsEditable
@@ -21474,12 +21458,9 @@ class SharedWorker extends AbstractWorker {
@DocsEditable
factory SharedWorker(String scriptURL, [String name]) {
- if (!?name) {
- return SharedWorker._create(scriptURL);
- }
- return SharedWorker._create(scriptURL, name);
+ return SharedWorker._create_1(scriptURL, name);
}
- static SharedWorker _create(String scriptURL, [String name]) native "SharedWorker_constructor_Callback";
+ static SharedWorker _create_1(scriptURL, name) native "SharedWorker_create_1_constructor_Callback";
@DomName('SharedWorker.port')
@DocsEditable
@@ -21837,8 +21818,10 @@ class SpeechGrammar extends NativeFieldWrapperClass1 {
SpeechGrammar.internal();
@DocsEditable
- factory SpeechGrammar() => SpeechGrammar._create();
- static SpeechGrammar _create() native "SpeechGrammar_constructor_Callback";
+ factory SpeechGrammar() {
+ return SpeechGrammar._create_1();
+ }
+ static SpeechGrammar _create_1() native "SpeechGrammar_create_1_constructor_Callback";
@DomName('SpeechGrammar.src')
@DocsEditable
@@ -21870,8 +21853,10 @@ class SpeechGrammarList extends NativeFieldWrapperClass1 implements List<SpeechG
SpeechGrammarList.internal();
@DocsEditable
- factory SpeechGrammarList() => SpeechGrammarList._create();
- static SpeechGrammarList _create() native "SpeechGrammarList_constructor_Callback";
+ factory SpeechGrammarList() {
+ return SpeechGrammarList._create_1();
+ }
+ static SpeechGrammarList _create_1() native "SpeechGrammarList_create_1_constructor_Callback";
@DomName('SpeechGrammarList.length')
@DocsEditable
@@ -22188,8 +22173,10 @@ class SpeechRecognition extends EventTarget {
static const EventStreamProvider<Event> startEvent = const EventStreamProvider<Event>('start');
@DocsEditable
- factory SpeechRecognition() => SpeechRecognition._create();
- static SpeechRecognition _create() native "SpeechRecognition_constructor_Callback";
+ factory SpeechRecognition() {
+ return SpeechRecognition._create_1();
+ }
+ static SpeechRecognition _create_1() native "SpeechRecognition_create_1_constructor_Callback";
/// Checks if this type is supported on the current platform.
static bool get supported => true;
@@ -23719,8 +23706,10 @@ class TextTrackCue extends EventTarget {
static const EventStreamProvider<Event> exitEvent = const EventStreamProvider<Event>('exit');
@DocsEditable
- factory TextTrackCue(num startTime, num endTime, String text) => TextTrackCue._create(startTime, endTime, text);
- static TextTrackCue _create(num startTime, num endTime, String text) native "TextTrackCue_constructor_Callback";
+ factory TextTrackCue(num startTime, num endTime, String text) {
+ return TextTrackCue._create_1(startTime, endTime, text);
+ }
+ static TextTrackCue _create_1(startTime, endTime, text) native "TextTrackCue_create_1_constructor_Callback";
@DocsEditable
@DomName('EventTarget.addEventListener, EventTarget.removeEventListener, EventTarget.dispatchEvent')
@@ -27746,8 +27735,21 @@ class WebSocket extends EventTarget {
static const EventStreamProvider<Event> openEvent = const EventStreamProvider<Event>('open');
@DocsEditable
- factory WebSocket(String url) => WebSocket._create(url);
- static WebSocket _create(String url) native "WebSocket_constructor_Callback";
+ factory WebSocket(String url, [protocol_OR_protocols]) {
+ if ((url is String || url == null) && !?protocol_OR_protocols) {
+ return WebSocket._create_1(url);
+ }
+ if ((url is String || url == null) && (protocol_OR_protocols is List<String> || protocol_OR_protocols == null)) {
+ return WebSocket._create_2(url, protocol_OR_protocols);
+ }
+ if ((url is String || url == null) && (protocol_OR_protocols is String || protocol_OR_protocols == null)) {
+ return WebSocket._create_3(url, protocol_OR_protocols);
+ }
+ throw new ArgumentError("Incorrect number or type of arguments");
+ }
+ static WebSocket _create_1(url) native "WebSocket_create_1_constructor_Callback";
+ static WebSocket _create_2(url, protocol_OR_protocols) native "WebSocket_create_2_constructor_Callback";
+ static WebSocket _create_3(url, protocol_OR_protocols) native "WebSocket_create_3_constructor_Callback";
/// Checks if this type is supported on the current platform.
static bool get supported => true;
@@ -28898,8 +28900,10 @@ class Worker extends AbstractWorker {
static const EventStreamProvider<MessageEvent> messageEvent = const EventStreamProvider<MessageEvent>('message');
@DocsEditable
- factory Worker(String scriptUrl) => Worker._create(scriptUrl);
- static Worker _create(String scriptUrl) native "Worker_constructor_Callback";
+ factory Worker(String scriptUrl) {
+ return Worker._create_1(scriptUrl);
+ }
+ static Worker _create_1(scriptUrl) native "Worker_create_1_constructor_Callback";
@DocsEditable
@DomName('EventTarget.addEventListener, EventTarget.removeEventListener, EventTarget.dispatchEvent')
@@ -29158,8 +29162,10 @@ class XPathEvaluator extends NativeFieldWrapperClass1 {
XPathEvaluator.internal();
@DocsEditable
- factory XPathEvaluator() => XPathEvaluator._create();
- static XPathEvaluator _create() native "XPathEvaluator_constructor_Callback";
+ factory XPathEvaluator() {
+ return XPathEvaluator._create_1();
+ }
+ static XPathEvaluator _create_1() native "XPathEvaluator_create_1_constructor_Callback";
@DomName('XPathEvaluator.createExpression')
@DocsEditable
@@ -29323,8 +29329,10 @@ class XmlSerializer extends NativeFieldWrapperClass1 {
XmlSerializer.internal();
@DocsEditable
- factory XmlSerializer() => XmlSerializer._create();
- static XmlSerializer _create() native "XMLSerializer_constructor_Callback";
+ factory XmlSerializer() {
+ return XmlSerializer._create_1();
+ }
+ static XmlSerializer _create_1() native "XMLSerializer_create_1_constructor_Callback";
@DomName('XMLSerializer.serializeToString')
@DocsEditable
@@ -29344,8 +29352,10 @@ class XsltProcessor extends NativeFieldWrapperClass1 {
XsltProcessor.internal();
@DocsEditable
- factory XsltProcessor() => XsltProcessor._create();
- static XsltProcessor _create() native "XSLTProcessor_constructor_Callback";
+ factory XsltProcessor() {
+ return XsltProcessor._create_1();
+ }
+ static XsltProcessor _create_1() native "XSLTProcessor_create_1_constructor_Callback";
@DomName('XSLTProcessor.clearParameters')
@DocsEditable

Powered by Google App Engine
This is Rietveld 408576698