Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 12052040: Added step that saves OAuth2 tokens fetched through policy into TokenService. (Closed)

Created:
7 years, 11 months ago by zel
Modified:
7 years, 11 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Added step that saves OAuth2 tokens fetched through policy into TokenService. Kudos to Joao for nailing this problem down in https://codereview.chromium.org/12039044/. BUG=170725 TEST=make sure that sync works for newly created ent entrolled accounts Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178339

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M chrome/browser/chromeos/login/oauth2_login_manager.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/oauth2_login_manager.cc View 1 5 chunks +13 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
zel
7 years, 11 months ago (2013-01-23 17:22:08 UTC) #1
zel
7 years, 11 months ago (2013-01-23 17:37:31 UTC) #2
xiyuan
LGTM
7 years, 11 months ago (2013-01-23 17:43:26 UTC) #3
Joao da Silva
lgtm
7 years, 11 months ago (2013-01-23 17:50:02 UTC) #4
Nikita (slow)
7 years, 11 months ago (2013-01-24 12:29:28 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698