Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: pkg/oauth2/lib/src/authorization_code_grant.dart

Issue 12052038: Rename new Uri.fromString to Uri.parse. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reupload because of Error. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « pkg/oauth2/lib/oauth2.dart ('k') | pkg/oauth2/lib/src/credentials.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library authorization_code_grant; 5 library authorization_code_grant;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:uri'; 8 import 'dart:uri';
9 9
10 // TODO(nweiz): This should be a "package:" import. See issue 6745. 10 // TODO(nweiz): This should be a "package:" import. See issue 6745.
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 } else if (parameters['state'] != _stateString) { 178 } else if (parameters['state'] != _stateString) {
179 throw new FormatException('Invalid OAuth response for ' 179 throw new FormatException('Invalid OAuth response for '
180 '"$authorizationEndpoint": parameter "state" expected to be ' 180 '"$authorizationEndpoint": parameter "state" expected to be '
181 '"$_stateString", was "${parameters['state']}".'); 181 '"$_stateString", was "${parameters['state']}".');
182 } 182 }
183 } 183 }
184 184
185 if (parameters.containsKey('error')) { 185 if (parameters.containsKey('error')) {
186 var description = parameters['error_description']; 186 var description = parameters['error_description'];
187 var uriString = parameters['error_uri']; 187 var uriString = parameters['error_uri'];
188 var uri = uriString == null ? null : new Uri.fromString(uriString); 188 var uri = uriString == null ? null : Uri.parse(uriString);
189 throw new AuthorizationException(parameters['error'], description, uri); 189 throw new AuthorizationException(parameters['error'], description, uri);
190 } else if (!parameters.containsKey('code')) { 190 } else if (!parameters.containsKey('code')) {
191 throw new FormatException('Invalid OAuth response for ' 191 throw new FormatException('Invalid OAuth response for '
192 '"$authorizationEndpoint": did not contain required parameter ' 192 '"$authorizationEndpoint": did not contain required parameter '
193 '"code".'); 193 '"code".');
194 } 194 }
195 195
196 return _handleAuthorizationCode(parameters['code']); 196 return _handleAuthorizationCode(parameters['code']);
197 }); 197 });
198 } 198 }
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 /// Closes the grant and frees its resources. 250 /// Closes the grant and frees its resources.
251 /// 251 ///
252 /// This will close the underlying HTTP client, which is shared by the 252 /// This will close the underlying HTTP client, which is shared by the
253 /// [Client] created by this grant, so it's not safe to close the grant and 253 /// [Client] created by this grant, so it's not safe to close the grant and
254 /// continue using the client. 254 /// continue using the client.
255 void close() { 255 void close() {
256 if (_httpClient != null) _httpClient.close(); 256 if (_httpClient != null) _httpClient.close();
257 _httpClient = null; 257 _httpClient = null;
258 } 258 }
259 } 259 }
OLDNEW
« no previous file with comments | « pkg/oauth2/lib/oauth2.dart ('k') | pkg/oauth2/lib/src/credentials.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698