Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: pkg/http/lib/src/base_client.dart

Issue 12052038: Rename new Uri.fromString to Uri.parse. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reupload because of Error. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pkg/http/lib/src/multipart_request.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library base_client; 5 library base_client;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:io'; 8 import 'dart:io';
9 import 'dart:scalarlist'; 9 import 'dart:scalarlist';
10 import 'dart:uri'; 10 import 'dart:uri';
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 /// later point, or it could already be closed when it's returned. 103 /// later point, or it could already be closed when it's returned.
104 Future<StreamedResponse> send(BaseRequest request); 104 Future<StreamedResponse> send(BaseRequest request);
105 105
106 /// Sends a non-streaming [Request] and returns a non-streaming [Response]. 106 /// Sends a non-streaming [Request] and returns a non-streaming [Response].
107 Future<Response> _sendUnstreamed( 107 Future<Response> _sendUnstreamed(
108 String method, url, Map<String, String> headers, 108 String method, url, Map<String, String> headers,
109 [Map<String, String> fields]) { 109 [Map<String, String> fields]) {
110 // Wrap everything in a Future block so that synchronous validation errors 110 // Wrap everything in a Future block so that synchronous validation errors
111 // are passed asynchronously through the Future chain. 111 // are passed asynchronously through the Future chain.
112 return async.then((_) { 112 return async.then((_) {
113 if (url is String) url = new Uri.fromString(url); 113 if (url is String) url = Uri.parse(url);
114 var request = new Request(method, url); 114 var request = new Request(method, url);
115 115
116 if (headers != null) mapAddAll(request.headers, headers); 116 if (headers != null) mapAddAll(request.headers, headers);
117 if (fields != null && !fields.isEmpty) request.bodyFields = fields; 117 if (fields != null && !fields.isEmpty) request.bodyFields = fields;
118 118
119 return send(request); 119 return send(request);
120 }).then(Response.fromStream); 120 }).then(Response.fromStream);
121 } 121 }
122 122
123 /// Throws an error if [response] is not successful. 123 /// Throws an error if [response] is not successful.
124 void _checkResponseSuccess(url, Response response) { 124 void _checkResponseSuccess(url, Response response) {
125 if (response.statusCode < 400) return; 125 if (response.statusCode < 400) return;
126 var message = "Request to $url failed with status ${response.statusCode}"; 126 var message = "Request to $url failed with status ${response.statusCode}";
127 if (response.reasonPhrase != null) { 127 if (response.reasonPhrase != null) {
128 message = "$message: ${response.reasonPhrase}"; 128 message = "$message: ${response.reasonPhrase}";
129 } 129 }
130 throw new HttpException("$message."); 130 throw new HttpException("$message.");
131 } 131 }
132 132
133 /// Closes the client and cleans up any resources associated with it. It's 133 /// Closes the client and cleans up any resources associated with it. It's
134 /// important to close each client when it's done being used; failing to do so 134 /// important to close each client when it's done being used; failing to do so
135 /// can cause the Dart process to hang. 135 /// can cause the Dart process to hang.
136 void close() {} 136 void close() {}
137 } 137 }
OLDNEW
« no previous file with comments | « no previous file | pkg/http/lib/src/multipart_request.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698