Add "frame to navigate" to NavigationEntry and plumb it to the RenderViewImpl

content/browser/web_contents/navigation_entry_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_WEB_CONTENTS_NAVIGATION_ENTRY_IMPL_H_
 #define CONTENT_BROWSER_WEB_CONTENTS_NAVIGATION_ENTRY_IMPL_H_
 
 #include "base/basictypes.h"
 #include "base/memory/ref_counted.h"
 #include "content/browser/site_instance_impl.h"
@@ skipping 55 matching lines @@
   virtual const SSLStatus& GetSSL() const OVERRIDE;
   virtual SSLStatus& GetSSL() OVERRIDE;
   virtual void SetOriginalRequestURL(const GURL& original_url) OVERRIDE;
   virtual const GURL& GetOriginalRequestURL() const OVERRIDE;
   virtual void SetIsOverridingUserAgent(bool override) OVERRIDE;
   virtual bool GetIsOverridingUserAgent() const OVERRIDE;
   virtual void SetTimestamp(base::Time timestamp) OVERRIDE;
   virtual base::Time GetTimestamp() const OVERRIDE;
   virtual void SetCanLoadLocalResources(bool allow) OVERRIDE;
   virtual bool GetCanLoadLocalResources() const OVERRIDE;
+  virtual void SetFrameToNavigate(const std::string& frame_name) OVERRIDE;
+  virtual const std::string& GetFrameToNavigate() const OVERRIDE;
 
   void set_unique_id(int unique_id) {
     unique_id_ = unique_id;
   }
 
   // The SiteInstance tells us how to share sub-processes. This is a reference
   // counted pointer to a shared site instance.
   //
   // Note that the SiteInstance should usually not be changed after it is set,
   // but this may happen if the NavigationEntry was cloned and needs to use a
@@ skipping 166 matching lines @@
   //
   // We also use this flag for cross-process redirect navigations, so that the
   // browser will replace the current navigation entry (which is the page
   // doing the redirect).
   bool should_replace_entry_;
 
   // Set when this entry should be able to access local file:// resources. This
   // value is not needed after the entry commits and is not persisted.
   bool can_load_local_resources_;
 
+  // If not empty, the name of the frame to navigate.

[Charlie Reis, 2013/01/23 01:38:45]

Should this be persisted?  (See the warning above.)

I would worry about a restored tab sending the navigation to the main frame
instead of the intended subframe, even if this is only used in tests.

[jochen (gone - plz use gerrit), 2013/01/23 08:22:42]

I'd rather not persist test-only data. I added a DCHECK to the session restore
system to make sure this doesn't happen accidentally.

+  std::string frame_to_navigate_;
+
   // Copy and assignment is explicitly allowed for this class.
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_WEB_CONTENTS_NAVIGATION_ENTRY_IMPL_H_